Openssl #294
Open
Openssl #294
+50
−844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openssl has many config options controlling the included algrithms. Make them configureable by `OPENSSL_ADDITIONAL_OPTIONS`.
Openssl uses plugins via (dlopen). If plugins are used for host-openssl the host build must use shared linkage. Provide an option to override the default link mode.
Update openssl to latest LTS Release.
jkloetzke
reviewed
Jan 25, 2026
| patchApplySeries $<@openssl/*.patch@> | ||
| Config: | ||
| OPENSSL_ADDITIONAL_OPTIONS: |
Member
There was a problem hiding this comment.
Does it make sense to name the algorithms explicitly like buildroot does? This catch-all variable seems a bit coarse grained. Even if not done now, would it be a problem on your side if we go in this direction?
| Config: | ||
| OPENSSL_ADDITIONAL_OPTIONS: | ||
| help: additional configure options | ||
| OPENSSL_LINK_MODE: |
Member
There was a problem hiding this comment.
The idea for such things was to set BASEMENT_LIBS to shared when declaring the dependency:
depends:
- name: libs::openssl
environment:
BASEMENT_LIBS: sharedThis will override the heuristic for cpackageLibraryType. Of course, this will apply for the dependencies as well.
Actually, I think our openssl recipe is wrong and should pass no-dso in case of static linking. At least buildroot does that and it looks correct to me. Would you mind fixing that with a separate commit while you're at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.