Skip to content

Conversation

@stephanmg
Copy link
Collaborator

@stephanmg stephanmg commented Nov 21, 2025

Empty fields (e.g. for plotName) lead to 'nan' value for title of plot.

Therefore changed empty fields to a field entry with the space character.

@stephanmg
Copy link
Collaborator Author

Potentially only relevant for rather old petab versions, tested version with this issue is <=0.5.0.

@stephanmg stephanmg marked this pull request as draft November 21, 2025 17:40
Copy link
Collaborator

@plakrisenko plakrisenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files are changed

@stephanmg stephanmg marked this pull request as ready for review November 24, 2025 14:41
@dilpath
Copy link
Collaborator

dilpath commented Nov 26, 2025

Should this be fixed in the plotting code instead?

@stephanmg
Copy link
Collaborator Author

Should this be fixed in the plotting code instead?

I think the issue is only reproducible in older petab versions - so, we could also discard my changes and argue not to use older petab versions).

@dilpath dilpath closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants