-
Notifications
You must be signed in to change notification settings - Fork 0
improve userSync settings handling #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
* Add Scalibur bid adapter with comprehensive tests * finish scalibur bid adapter and tests * fix * fix * add missing params * convert response price to cpm * size to valid format * fix tests * remove all uses of first party data and Math.random * fix lint error * fix some more lint errors * add support to own fpd * vlaidate tests and lint * re tests * rerun tests * remove the use of navigator --------- Co-authored-by: Timor Bibi <timor@Timors-MacBook-Pro-2.local>
…en necessary (prebid#13929) * cachedApiWrapper * lazy access target * make parent available to getTarget * simplify * consolidate extraWinDimensions * Remove sketchy dimensions * adnuntius: remove availWidth/availHeight * onetag: stop using outer & avail dims --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* Core: targeting bids limit varying on ad unit * handling other case * refactoring * moving bidLimit to adUnit level * fixing sendAllBids issue, allowing adunitBidLimit as object * restoring missing comment * performance optimization
…3944) * Yandex Bid Adapter: Added banner coordinates to the request * fix webdriver * Yandex Bid Adapter: Added banner coordinates to the request * Yandex Bid Adapter: Added banner coordinates to the request * Update modules/yandexBidAdapter.js Co-authored-by: Graham Higgins <gwhigs@gmail.com> --------- Co-authored-by: Graham Higgins <gwhigs@gmail.com>
Co-authored-by: mderevyanko <mderevyanko24@gmail.com>
Bumps [karma-spec-reporter](https://github.com/tmcgee123/karma-spec-reporter) from 0.0.32 to 0.0.36. - [Commits](tmcgee123/karma-spec-reporter@v0.0.32...v0.0.36) --- updated-dependencies: - dependency-name: karma-spec-reporter dependency-version: 0.0.36 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
…id#13992) Including the tags in GAM is still controlled from the module configuration level. Generating them on the server side gives us more flexibility and simplifies user module.
Co-authored-by: Andy <arezitopedia@gmail.com>
… consent checks (prebid#14004) Co-authored-by: slimkrazy <sam@nodls.ai>
* Core: wait for creative document DOMContentLoaded * start browserstacklocal explicitly * debug * debug * capitalization * start as daemon * Undo unrelated change
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* msftBidAdapter - new adapter to eventually replace appnexusBidAdapter * add unit test file * fix import issue in tests * fix lint issue in adapter file * add more tests * add more tests * update banner test * update comment * another set of updates * update unit tests * update to readme * remove tid code * remove some comments, fix type checks, remove unneeded response function * edit other comments * try to fix lint errors --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* [craftBidder] Add user.eids to request * [craftBidder] Add user.eids to request add test --------- Co-authored-by: Monis Qadri <monis0395@users.noreply.github.com>
* EmpowerBidAdapter: initial release * EmpowerBidAdapter: initial release * some code changes after lint check * test bannerServerRequest changes from local url to server url * some fixes and improvements * unceswsary line removed --------- Co-authored-by: Monis Qadri <monis0395@users.noreply.github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.28.3 to 7.28.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.4/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-version: 7.28.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update optableRtdProvider.md * Update optableRtdProvider.md
* [ATS-68316] Update to get userId as per prebid version 10+ * [ATS-68316] Add unit test case for the fix --------- Co-authored-by: Sunath <sunath@liveramp.com>
…king capability (prebid#13945) * SmartyTech Bid Adapter: Add userId, consent data support and chunking capability - Add userIdAsEids transmission when available - Add GDPR, CCPA/USP, and COPPA consent support - Add configurable chunking of bid requests to control number of ads per request - Maintain backward compatibility - Add comprehensive test coverage for all new features Results of gulp lint: ✅ No issues Results of gulp test: ✅ All tests pass * Smartytech bid adapter. Avoid send undefined for gdprApplies and guarantee for config get
…d#13899) * feat(analytics): added Datawrkz analytics adapter * fix(analytics): lint fixes for Datawrkz Analytics Adapter * fix(analytics): lint fixes for Datawrkz Analytics Adapter * feat(analytics): add publisherId and apiKey config in Datawrkz Analytics Adapter * Datawrkz Analytics Adapter: add tests for publisherId and apiKey config --------- Co-authored-by: Monis Qadri <monis0395@users.noreply.github.com> Co-authored-by: Love Sharma <sharmak.love@gmail.com>
* feat: track auction events * style: lint files * perf: add keepalive on tracking request * fix: ajax content type * test: ajax content type * perf: remove json content type to avoid preflight request --------- Co-authored-by: Andrea Fassina <fasenderos@gmail.com>
* adding glvid to the omnidex * fixing test
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.45.1 to 3.46.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.46.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-version: 3.46.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandr Kim <alexandr.kim@audienzz.ch>
…rebid#14026) * Build system: adjust karma timeouts * use browserstack own action for setup * use 127.0.0.1 instead of localhost * revert dependency changes * disable dependabot * Undo timeout changes * increase disconnect tolerance * fix version and schema-utils in package.json * fix versions (again) * Allow dependabot updates to type definitions * Change dependency update schedule to monthly Changed the update schedule for GitHub Actions and npm dependencies from weekly to monthly. Added additional dependencies to the allow list. * Update Babel dependencies in dependabot configuration * Change npm dependency update interval to quarterly --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 8.5.12 to 8.18.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws) --- updated-dependencies: - dependency-name: "@types/ws" dependency-version: 8.18.1 dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [min-document](https://github.com/Raynos/min-document) from 2.19.0 to 2.19.2. - [Commits](Raynos/min-document@v2.19.0...v2.19.2) --- updated-dependencies: - dependency-name: min-document dependency-version: 2.19.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* try safari testing * try macos-latest * adjust save/load * adjust again * why * adjust -C * try safarinative * use SafariNative * separate build from run-tests * browser tests * add safari * refactor * use setup step * add firefoxHeadless * add edge * try force-local * temporarily remove build logic testing * --force-local only on win * add npm install to build * run npm install on windows * use script to generate id * use --force-local on save as well * setup edge * remove run npm install option * enable debug logging * try edge headless * define EdgeHeadless * try chromium edge * remove edge launcher * disable debug logging * add build logic test step * set shell bash * move id generation to actions/save * browser_testing.json * fix coverage * add browerstack * fix bstack secrets * remove unnecessary checkout * Clean up unused input * try clearing localStorage
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.9 to 3.1.1. - [Commits](mafintosh/tar-fs@v3.0.9...v3.1.1) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 3.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps and [js-yaml](https://github.com/nodeca/js-yaml). These dependencies needed to be updated together. Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Public Good new adapter * fix typo --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
Bumps [glob](https://github.com/isaacs/node-glob) from 10.4.5 to 10.5.0. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v10.5.0) --- updated-dependencies: - dependency-name: glob dependency-version: 10.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps [axios](https://github.com/axios/axios) from 1.9.0 to 1.13.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.9.0...v1.13.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.13.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * Cache deps
No longer needed in 10
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change * look at reviews as well as requested reviewers * add an extra authorized reviewer check * Do not consider negative engineers
* test arguments * declare environ * environment name * I like secrets * Revert "I like secrets" This reverts commit dc07a6a. * try getPRProperties * local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * test integration * self-contained workflow * Cache deps * Install dependencies * pass PR number * WIP pr bot * Update PR assignment script * typo * undo unrelated change * look at reviews as well as requested reviewers * add an extra authorized reviewer check * Do not consider negative engineers * do not request reviewers that have already reviewed
…4143) * Read currency configs * Add tests for the currency handling
* local e2e testing * rework concurrency id * clean up inputs * try installing safari * specify shell * try npx * break out build from test for e2e * try safaridriver --enable * adjust build, safaridriver * safari why such a pain * safari * safari... * do not allow parallel tests * try to install chrome 109 * log browsers * deb installation * fix deb installation * extract install-deb * fix install-deb * more flexible version definition * remove safari 15 * disable coverage on chrome 109 * Better job names * bump chrome 109 -> 113, and add logic to test it outside browserstack * reintroduce safari 15.6 * try --no-sandbox * rename custom -> noSandbox * update wait for browserstack to accept variable number of sessions * fix type error
…cts (prebid#14171) * Add weakCachec to objectGuard * add unit test * lint --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* Start.io adapter: Change the protocol from http to https * Start.io adapter: Changing content-type to json * Start.io adapter: Changing content-type back to text/plain
…bid#14044) * Add SeenThis Brand Stories module * test: add unit tests for seenthisBrandStories module functions and constants * remove support for loading inside iframe * only allow events of seenthis origin * fix tests; update applying of styling * sort variables * emit billable event on init --------- Co-authored-by: Per Holmäng <per.holmang@gmail.com>
* GreenbidsBidAdapter: fix tests * fix adnuntius & pbsBidAdapter
* Screencore prebid adapter * rearrange code * use lowercase screncore bidder code * fix tests * update tests * trigger CI * Screencore Bid Adapter: add endpointId parameter * Updated adapter to use teqblazeUtils library * Added endpointId parameter support in test parameters * Updated test specs to include endpointId validation * Screencore Bid Adapter: update sync URL to base domain Update SYNC_URL constant to use base domain. The getUserSyncs function from teqblazeUtils will append the appropriate path. * Screencore Bid Adapter: migrate to teqblazeUtils library - Update imports to use buildRequestsBase, interpretResponse, getUserSyncs, isBidRequestValid, and buildPlacementProcessingFunction from teqblazeUtils - Remove storage manager dependency (no longer needed) - Update isBidRequestValid to use placementId/endpointId params validation - Refactor buildRequests to use buildRequestsBase pattern - Rewrite test suite to match teqblazeUtils API: - Simplify test data structures - Update server response format (body as array) - Add tests for placementId/endpointId validation - Update getUserSyncs URL format expectations --------- Co-authored-by: Kostiantyn Karchevsky <kostiantyn.karchevsky@teqblaze.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…#14197) Co-authored-by: Patrick McCann <patmmccann@gmail.com>
A bitwise `&` was being used instead of the intended `|`.
775c359 to
e91be0e
Compare
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
| return win; | ||
| } | ||
| function _getDNT(win) { | ||
| return win.navigator.doNotTrack === '1' || win.doNotTrack === '1' || win.navigator.msDoNotTrack === '1' || win.navigator.doNotTrack?.toLowerCase?.() === 'yes'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incomplete DNT string value handling
The _getDNT function only checks for the string value 'yes' on win.navigator.doNotTrack but not on win.doNotTrack or win.navigator.msDoNotTrack. The previous implementation normalized all DNT values to lowercase and checked for both '1' and 'yes' uniformly across all properties. This means if win.doNotTrack or win.navigator.msDoNotTrack is set to the string 'yes' (case-insensitive), it won't be detected as DNT being active, breaking compatibility with browsers that use this value format.
| } | ||
| lastPageUrl = window.location.pathname; | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Request counter not reset on page change
The getRequestCount function fails to reset requestCounter when detecting a page change. When lastPageUrl differs from the current pathname, the function updates lastPageUrl and returns 0, but leaves requestCounter at its previous value. On the next call, ++requestCounter increments from the old value instead of starting from 1, causing incorrect request counts after navigation. The counter should be reset to 0 when the page changes, as implemented in the similar function in kargoBidAdapter.js.
Note
Adds TID source/consistency controls and per-bidder pageView IDs, defers queue processing, waits DOM ready for rendering, refines targeting/bid limits, and updates utils/tests/adapters.
source.ext.tidSourceandortb2Imp.ext.tidSource; generate TIDs viatidFactorywithenableTIDsandconsistentTIDs.source.tid/publisherext.tid.pageViewIdand addrefreshPageViewId().cmd/queexecution until setup completes.getAdUnitBidLimitMap; handle adUnit-specific limits.CachedApiWrapper; rework win dimensions caching; add domain/query cleanup helpers.Written by Cursor Bugbot for commit e91be0e. This will update automatically on new commits. Configure here.