Skip to content

Conversation

@sawenzel
Copy link
Contributor

The CCDB remapping arguments appeared sometimes correctly quoted and in some cases not. This is because the task_finalizer reapplied string construction/quoting which was not generic enough.

This is fixed with this commit.

In addition, we now automatically quote ALIEN_JDL_REMAPPING if needed.

Both versions

export ALIEN_JDL_REMAPPING="foo;bar"

as well as (quoted)

export ALIEN_JDL_REMAPPING='"foo;bar"'

will work. It is recommended to just use the former.

The CCDB remapping arguments appeared sometimes correctly quoted and in some cases not.
This is because the task_finalizer reapplied string construction/quoting which was not generic enough.

This is fixed with this commit.

In addition, we now automatically quote ALIEN_JDL_REMAPPING if needed.

Both versions
```
export ALIEN_JDL_REMAPPING="foo;bar"
```
as well as (quoted)
```
export ALIEN_JDL_REMAPPING='"foo;bar"'
```
will work. It is recommended to just use the former.
@sawenzel sawenzel requested a review from jackal1-66 as a code owner October 21, 2025 12:23
@sawenzel
Copy link
Contributor Author

@shahor02 @catalinristea

@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@shahor02
Copy link
Collaborator

Thanks!

@shahor02
Copy link
Collaborator

Tested locally, works as needed, merging.

@shahor02 shahor02 merged commit 8ccc999 into AliceO2Group:master Oct 22, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants