feat: Gene seed overhaul #387

OH296 · 2025-01-05T20:38:55Z

Description of changes

make gene seed their own objects
this means the mutations of each gene seed are stored and viewable before implantation
gene seed defects will pass on to other gene seed in placed in slave incubators
- this incentivises players to put their best gene seed in slave pods
- leverages apothecary points for screening of gene seed
better control of mutations more options for gameplay with stability and purity
harvested gene seed from marines will retain the mutations of their parent marine

Reasons for changes

How have you tested your changes?

Summary by Sourcery

Introduce gene seed as objects, allowing players to view mutations before implantation. Implement gene seed defects inheritance in slave incubators, encouraging strategic gene seed placement. Improve mutation control with stability and purity mechanics. Harvested gene seed will inherit parent marine mutations. Update mechanicus tithes to use the new gene seed system.

New Features:

Gene seed is now tracked as objects, with mutations stored and viewable before implantation.
Gene seed defects can be passed on to other gene seed in slave incubators.
Improved mutation control with new stability and purity options.

Tests:

Compile
New game
Next turn
Space Travel
Ground Battle

Blogaugis · 2025-02-09T11:55:42Z

objects/obj_controller/Create_0.gml

+}
+
+if (scr_has_disadv("Obliterated")){
+    _gene_count= irandom_range(50,200);


Should obliterated really have less gene-seed available on start than even sieged?

Blogaugis · 2025-02-09T11:59:33Z

objects/obj_p_ship/Alarm_3.gml

        }
        if (obj_controller.und_gene_vaults>0){
-            obj_controller.gene_seed-=floor(obj_controller.gene_seed/10);
+            remove_gene_seed(floor(gene_seed_count()/10));


Might be something to consider in the future:
Should gene-seed taken by enemy forces be tracked? Player can trade gene-seed with most of factions after all.
And while for most it may be of little use, for CSMs it should be very valuable item that affects their power.

Blogaugis · 2025-02-09T12:04:19Z

objects/obj_popup/Step_0.gml

-		if (obj_controller.gene_seed <= 30) {
+		var _gene_count = gene_seed_count();
+		if (_gene_count <= 30) {
 			option1 += "100% of the gene-seed.";


It is weird that game punishes the player when less gene-seed is available (albeit the event does not occur if you have 5 or less, but that info is for pros or who read the code).
I think we should consider making it inverted, and influenced by the amount of apothecaries - the more gene-seed you have, the harder it is to keep track of them. But this is alleviated by apothecaries - they can pinpoint the mutations occuring, and help in minimizing the amount you need to dispose of.

coderabbitai · 2025-03-02T00:43:29Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

EttyKitty · 2025-03-20T14:36:51Z

Can we, as a part of this, have "organs" as a new struct attached to each marine, similar to body? There you can store each gene-seed organ, normal organs, bionic organ replacements, what mutations each organ has, maybe health/problems of each part, etc.
I partly ask this because it would be good to separate "the lack" of an organ, from actual mutations, as rn a lot of mutations that we have are just "you don't have the organ".
That is, if what I'm talking about is in any way related to work being done here.

Some reference re missing organs and mutations.

github-actions · 2025-04-07T01:14:14Z

This PR is marked as stale, because it has been open for 7 days with no activity.

github-actions · 2025-05-06T22:24:21Z

This PR is marked as stale, because it has been open for 7 days with no activity.

Blogaugis · 2025-06-16T15:09:17Z

A bit odd that Doomed mutation is an option between 2.
Which is either the actual Doomed, or BlackCarapaceAbsence - which wouldn't really be a Doomed state per se, more it would be a challenge run without Power Armour variants. At least, for newer marines.
Which could be interesting, especially if I get to tech tree expansion stuff.

github-actions · 2025-06-23T22:26:01Z

This PR is marked as stale, because it has been open for 7 days with no activity.

github-actions · 2025-07-02T22:24:42Z

This PR is marked as stale, because it has been open for 7 days with no activity.

OH296 changed the title ~~Gene seed overhaul~~ feat: Gene seed overhaul Jan 5, 2025

This comment was marked as outdated.

Sign in to view

OH296 marked this pull request as draft January 5, 2025 20:40

OH296 dismissed sourcery-ai[bot]’s stale review via b4c9681 January 6, 2025 19:14

OH296 added 5 commits January 6, 2025 19:15

in depth gene seed

950e05b

swap out for method

7dde751

cleanup after mass rework

75a32f3

rework unit death_handling

7936412

continued swap of gene_seed count method

3d4d348

OH296 force-pushed the gene_seed_overhaul branch from b4c9681 to 3d4d348 Compare January 6, 2025 19:16

Blogaugis reviewed Feb 9, 2025

View reviewed changes

github-actions bot added the Status: Stale No activity for more than a week label Mar 2, 2025

github-actions bot removed the Status: Stale No activity for more than a week label Mar 2, 2025

OH296 mentioned this pull request Mar 12, 2025

feat: Gene-seed and mutation related adjustments #586

Merged

Adeptus-Dominus deleted a comment from sourcery-ai bot Mar 20, 2025

github-actions bot added the Status: Stale No activity for more than a week label Apr 7, 2025

EttyKitty deleted the branch Adeptus-Dominus:main April 28, 2025 20:43

EttyKitty closed this Apr 28, 2025

EttyKitty reopened this Apr 28, 2025

EttyKitty changed the base branch from release/0.10.0.0 to main April 28, 2025 20:44

github-actions bot added Area: Sprites Changes to sprites/images or their under-the-hood functionality Size: Big Type: Feature Adds something new and removed Status: Stale No activity for more than a week labels Apr 28, 2025

github-actions bot added the Status: Stale No activity for more than a week label May 6, 2025

github-actions bot removed the Status: Stale No activity for more than a week label Jun 16, 2025

github-actions bot added Status: Stale No activity for more than a week and removed Status: Stale No activity for more than a week labels Jun 23, 2025

github-actions bot added the Status: Stale No activity for more than a week label Jul 2, 2025

feat: Gene seed overhaul #387

Are you sure you want to change the base?

feat: Gene seed overhaul #387

Uh oh!

Conversation

OH296 commented Jan 5, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Reasons for changes

Related links

How have you tested your changes?

Summary by Sourcery

Uh oh!

This comment was marked as outdated.

Uh oh!

Blogaugis Feb 9, 2025

Choose a reason for hiding this comment

Uh oh!

Blogaugis Feb 9, 2025

Choose a reason for hiding this comment

Uh oh!

Blogaugis Feb 9, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

EttyKitty commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

Blogaugis commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OH296 commented Jan 5, 2025 •

edited by sourcery-ai bot

Loading

coderabbitai bot commented Mar 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

EttyKitty commented Mar 20, 2025 •

edited

Loading