-
Notifications
You must be signed in to change notification settings - Fork 43
ci: Modify GameMaker build workflow and update dependencies #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the GameMaker build workflow to search for 'ChapterMaster.yyp' and upgraded Igor setup and build versions.
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughTech-Priest: Workflow updated to search specifically for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-06-16T17:08:08.239ZApplied to files:
📚 Learning: 2025-03-01T11:06:25.427ZApplied to files:
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/gamemaker_build.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the psychic power system was changed to be data-driven, with perils now able to occur on both successful and failed casts but with reduced frequency overall.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 424
File: scripts/scr_flavor/scr_flavor.gml:34-36
Timestamp: 2025-03-09T02:33:43.867Z
Learning: EttyKitty prefers to keep PRs focused on their stated goals and scope, and may decline to implement otherwise valid suggestions if they're not directly related to the PR's primary objective.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 579
File: objects/obj_enunit/Alarm_0.gml:200-202
Timestamp: 2025-03-11T01:38:19.874Z
Learning: EttyKitty welcomes easy, committable suggestions that improve documentation of code chunks, variables with strange names, and functions. Their codebase is generally lacking documentation, but they prioritize human-readable code above documentation.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 938
File: scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml:478-478
Timestamp: 2025-07-21T17:03:28.251Z
Learning: EttyKitty acknowledges when PRs contain scope creep and agrees that changes should be focused on the stated PR objectives, reinforcing their preference for keeping PRs narrowly scoped to their primary purpose.
📚 Learning: 2025-06-16T17:08:08.239Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.
Applied to files:
.github/workflows/gamemaker_build.yml
📚 Learning: 2025-06-16T17:27:19.459Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:27:19.459Z
Learning: GameMaker Studio 2025 does not exist as of June 2025; the latest version is 2024.13.1. Most third-party .yy file cleanup tools are outdated and incompatible with current GameMaker project formats.
Applied to files:
.github/workflows/gamemaker_build.yml
🔇 Additional comments (2)
.github/workflows/gamemaker_build.yml (2)
106-106: The databanks are placated, Tech-Priest. The servo-spirit ascends with purpose.The rites of verification have been completed. The v1.1.0 elevation is no phantasm—a stable covenant-binding released unto the 24th solar cycle of the eleventh month, 2025. The sacred codex reveals additions of merit: Xbox manufactorum support hath been forged anew, dependencies consecrated, and the Windows cmd.exe shell corrected to purge systemic discord.
No harbingers of instability manifest. The ascension proceeds with the machine's blessing.
98-98: The servo-spirit v1.2.1 existeth and beareth no curse of incompatibility, Tech-Priest.The archives confirmeth: bscotch/igor-setup@v1.2.1 manifests as legitimate decree, published in the eighth month of this final year, carrying only minor fabrication amendments—the inscription of email designation within user folder protocols. The transition from v1.1.4 holdeth no breaking alterations.
Yet vigilance remaineth warranted: this fabrication-chain dependency ascendeth untested within thy project's rites. Though the spirits declare no inherent malice in the version itself, confirmation through thy own trial-by-fire would fortify confidence ere deployment to the productive aether.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Purpose and Description
Testing done
Related things and/or additional context