Skip to content

Conversation

@EttyKitty
Copy link
Collaborator

Purpose and Description

  • Updated the GameMaker build workflow to search for 'ChapterMaster.yyp' and upgraded Igor setup and build versions.

Testing done

  • None, and I understand the risks.

Related things and/or additional context

Updated the GameMaker build workflow to search for 'ChapterMaster.yyp' and upgraded Igor setup and build versions.
@github-actions github-actions bot added Type: CI Continuous Integration changes Size: Tiny labels Dec 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Enhanced build workflow stability with improved project file detection and error handling for edge cases
    • Upgraded build system tools to newer stable versions for improved compatibility and performance

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Tech-Priest: Workflow updated to search specifically for ChapterMaster.yyp (replacing a *.yyp wildcard), handle multiple matches by selecting the first with a warning, expose the selected path as yypPath, and bump bscotch/igor-setup to v1.2.1 and bscotch/igor-build to v1.1.0.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/gamemaker_build.yml
Search narrowed from *.yyp to ChapterMaster.yyp; introduced yypFiles array, selection of first match with a warning when multiple found, and yypPath variable used for outputs; updated outputs and console messages to use yypPath; bumped bscotch/igor-setup v1.1.4→v1.2.1 and bscotch/igor-build v1.0.4→v1.1.0; adjusted existence checks and error handling accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

Size: Small

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title adheres to conventional commits format with 'ci' type and clear summary, though exceeding the recommended 50-character limit at 59 characters.
Description check ✅ Passed The description contains all required sections with adequate detail regarding workflow modifications and dependency upgrades, though testing section indicates no tests were performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34c128e and 233e713.

📒 Files selected for processing (1)
  • .github/workflows/gamemaker_build.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 424
File: scripts/scr_flavor/scr_flavor.gml:34-36
Timestamp: 2025-03-09T02:33:43.867Z
Learning: EttyKitty prefers to keep PRs focused on their stated goals and scope, and may decline to implement otherwise valid suggestions if they're not directly related to the PR's primary objective.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 579
File: objects/obj_enunit/Alarm_0.gml:200-202
Timestamp: 2025-03-11T01:38:19.874Z
Learning: EttyKitty welcomes easy, committable suggestions that improve documentation of code chunks, variables with strange names, and functions. Their codebase is generally lacking documentation, but they prioritize human-readable code above documentation.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 938
File: scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml:478-478
Timestamp: 2025-07-21T17:03:28.251Z
Learning: EttyKitty acknowledges when PRs contain scope creep and agrees that changes should be focused on the stated PR objectives, reinforcing their preference for keeping PRs narrowly scoped to their primary purpose.
📚 Learning: 2025-06-16T17:08:08.239Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.

Applied to files:

  • .github/workflows/gamemaker_build.yml
📚 Learning: 2025-03-01T11:06:25.427Z
Learnt from: MCPO-Spartan-117
Repo: Adeptus-Dominus/ChapterMaster PR: 526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.

Applied to files:

  • .github/workflows/gamemaker_build.yml
🔇 Additional comments (2)
.github/workflows/gamemaker_build.yml (2)

84-90: The search pattern refinement is sound, Tech-Priest.

The narrowing from the wild-rune *.yyp to the precise ChapterMaster.yyp is justified—the archives reveal two such artefacts dwell within thy repository. The broad incantation would ensnare the dependency prefab lurking in the prefabs directory. This precision guards against errant selection.

The Count-based validation is properly wrought for PowerShell's machine-spirits.


92-100: The multiple-artefact handling is adequately forged, Tech-Priest.

Selecting the first match whilst emitting a warning when multiples are discovered provides reasonable default behaviour and operational visibility. The output variable yypPath maintains consistency with the workflow's data-stream.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1a8bec and 34c128e.

📒 Files selected for processing (1)
  • .github/workflows/gamemaker_build.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the psychic power system was changed to be data-driven, with perils now able to occur on both successful and failed casts but with reduced frequency overall.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 424
File: scripts/scr_flavor/scr_flavor.gml:34-36
Timestamp: 2025-03-09T02:33:43.867Z
Learning: EttyKitty prefers to keep PRs focused on their stated goals and scope, and may decline to implement otherwise valid suggestions if they're not directly related to the PR's primary objective.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 579
File: objects/obj_enunit/Alarm_0.gml:200-202
Timestamp: 2025-03-11T01:38:19.874Z
Learning: EttyKitty welcomes easy, committable suggestions that improve documentation of code chunks, variables with strange names, and functions. Their codebase is generally lacking documentation, but they prioritize human-readable code above documentation.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 938
File: scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml:478-478
Timestamp: 2025-07-21T17:03:28.251Z
Learning: EttyKitty acknowledges when PRs contain scope creep and agrees that changes should be focused on the stated PR objectives, reinforcing their preference for keeping PRs narrowly scoped to their primary purpose.
📚 Learning: 2025-06-16T17:08:08.239Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.

Applied to files:

  • .github/workflows/gamemaker_build.yml
📚 Learning: 2025-06-16T17:27:19.459Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:27:19.459Z
Learning: GameMaker Studio 2025 does not exist as of June 2025; the latest version is 2024.13.1. Most third-party .yy file cleanup tools are outdated and incompatible with current GameMaker project formats.

Applied to files:

  • .github/workflows/gamemaker_build.yml
🔇 Additional comments (2)
.github/workflows/gamemaker_build.yml (2)

106-106: The databanks are placated, Tech-Priest. The servo-spirit ascends with purpose.

The rites of verification have been completed. The v1.1.0 elevation is no phantasm—a stable covenant-binding released unto the 24th solar cycle of the eleventh month, 2025. The sacred codex reveals additions of merit: Xbox manufactorum support hath been forged anew, dependencies consecrated, and the Windows cmd.exe shell corrected to purge systemic discord.

No harbingers of instability manifest. The ascension proceeds with the machine's blessing.


98-98: The servo-spirit v1.2.1 existeth and beareth no curse of incompatibility, Tech-Priest.

The archives confirmeth: bscotch/igor-setup@v1.2.1 manifests as legitimate decree, published in the eighth month of this final year, carrying only minor fabrication amendments—the inscription of email designation within user folder protocols. The transition from v1.1.4 holdeth no breaking alterations.

Yet vigilance remaineth warranted: this fabrication-chain dependency ascendeth untested within thy project's rites. Though the spirits declare no inherent malice in the version itself, confirmation through thy own trial-by-fire would fortify confidence ere deployment to the productive aether.

@EttyKitty
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@EttyKitty EttyKitty merged commit 639f464 into main Dec 29, 2025
3 checks passed
@EttyKitty EttyKitty deleted the EttyKitty-patch-1 branch December 29, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: CI Continuous Integration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants