Fix SFT + GA (gradient accumulation) #2897
Open
+44
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where gradient accumulation + sft would fail due to missing param sharding
FIXES: b/472309528
Tests
Added a unit test (integration test) for sft + ga
Manually tested via
python3 -m MaxText.sft_trainer MaxText/configs/base.yml run_name=mattdavidow-train-base base_output_directory=$output_dir dataset_path=$dataset steps=5 enable_checkpointing=False enable_goodput_recording=False use_sft=True gradient_accumulation_steps=5
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.