-
Notifications
You must be signed in to change notification settings - Fork 443
Refactor dockerfiles and deprecate stable_stack and jax_ai_image mode #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SurbhiJainUSC
wants to merge
1
commit into
main
Choose a base branch
from
refactor_docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+128
−449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35e49d0 to
823aa33
Compare
90c5dff to
7986057
Compare
2f2243a to
5726f1d
Compare
5726f1d to
69ab4e5
Compare
69ab4e5 to
a4b1510
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a4b1510 to
5bbce63
Compare
richjames0
approved these changes
Dec 29, 2025
Collaborator
richjames0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5bbce63 to
11916bb
Compare
khatwanimohit
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docker_build_dependency_image.shand delete unnecessary docker build modesmaxtext_jax_ai_image.Dockerfile,jetstream_pathways.Dockerfile,maxengine_server.Dockerfile,maxtext_db_dependenciesTODO: Deprecate
maxtext_custom_wheels.Dockerfilesoncetpu-recipesare migrated to usestable/nightlymodeTests
https://paste.googleplex.com/4931634182881280
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.