Fix loading files on pico builds #18
Open
+35
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also the check out of the cpp
This is still broken but now it compiles
Looking in /usr/local/share on a blit is not so useful. (For SDL this would be [game dir]/usr/local/,,, which is about as bad)
This means that require "thing" now works
Daft-Freak
force-pushed
the
patch-pico-fs
branch
from
ea60780 to
eaddd34
Compare
Contributor
Author
|
Now with more fixes so I can compile it again and |
Contributor
Author
|
Mmm, getting this working for SDL builds is harder... I have a patch to adjust the lua path so that require works (4e53e33), but that's still going to leave the file APIs pointing to the wrong place due to not using the stdio wrapper (which we can't do everywhere because apart from being a hack, it uses the gcc-specific I guess the only option left is patching the lua sources... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stdio wrapper there too.
I saw that the auto-builder built this for PicoVision and wondered if it actually worked. It didn't but the fix is easy and now it does.
Maybe this'll result in more users and/or improvements, who knows? 😆