Home work #1

1eonID · 2017-11-30T12:52:47Z

HW from Lesson 5, CRUD for DoctorController class

…hods. Part 1.

… and PetController classes.

mfarsikov · 2017-11-30T13:22:08Z

src/main/java/springee/doctor/DoctorController.java

+
+        if (doctor.getId() == null) {
+            synchronized (DoctorController.class) {
+                Integer index = doctorMap.size();


This solution works but:

Use class as monitor is not good idea.

Better to usage: with this as monitor (it is default monitor for synchronized { ... })

Even more better: avoid synchronization using non-blocking data types (Atomic....)

And the best solution: avoid any state and any counters

… and PetController classes. Avoid synchronization using non-blocking data type AtomicInteger.

…orController class into Doctor, Controller, Service and Repository classes.

…lasses.

…YAML config file and create methods getSpecializations and getSpecieList(in DoctorController class) for returning list of available specializations from application.yml file.

mfarsikov · 2017-12-07T17:18:00Z

src/main/java/springee/doctor/DoctorConfig.java

+
+    private List<String> specializations = new ArrayList<>();
+
+    public List<String> getSpecializations() {


mfarsikov · 2017-12-07T17:19:56Z

src/main/java/springee/doctor/DoctorRepository.java

+public class DoctorRepository {
+
+    @Autowired
+    private DoctorConfig  doctorConfig = new DoctorConfig();


use constructor injection

mfarsikov · 2017-12-07T17:20:26Z

src/main/java/springee/doctor/DoctorRepository.java

+
+    private final UUID uuid1 = UUID.randomUUID();
+    private final UUID uuid2 = UUID.randomUUID();
+    private final UUID uuid3 = UUID.randomUUID();


inline these fields

mfarsikov · 2017-12-07T17:26:01Z

src/main/java/springee/pet/PetController.java

  }};

-  Integer counter = 2;
+  private Map<Integer, Pet> synPets = Collections.synchronizedMap(pets);


this collection is thread-safe, but it is blocking. better choice: ConcurrentHashMap

@requiredargsconstructor

…ig class. Add annotation @requiredargsconstructor for using constructor injection in DoctorRepository class. Instead synchronizedMap added ConcurrentHashMap in PetController class. Don't inline UUID fields in DoctorRepository class, because we use Map.

… PostgreSQL DB. Remove class DoctorRepository and implement JpaRepository for working with DB. Change some methods in DoctorController and DoctorService classes for correct working with JPA.

…again - Remove class DoctorRepository and implement JpaRepository for working with DB. Change some methods in DoctorController and DoctorService classes for correct working with JPA.

…ization, for searching name of doctor ignoring case.

…octor schedule. Add date converter. Some changes in config files.

… for find method in JpaDoctorRepository interface. Change SpreengeeConfig.

…tor' in DoctorController class and update query in JpaDoctorRepository.

…tory, Service and Controller classes for Schedule. Refactor all classes in package 'doctor', for separating Doctor and Schedule entities.

… classes and methods with operations of validating from entities classes. Create 'dto' package and PetIdInputDto class for correct working with 'pet id' in Request Body.

mfarsikov · 2018-01-11T18:51:52Z

src/main/java/springee/schedule/ScheduleController.java

+        SortedMap<Integer, Integer> sortedSchedule = new TreeMap<>();
+        for (Schedule schedule: set) {
+            if(schedule.getDate().equals(date)) {
+                sortedSchedule.put(schedule.getTime(), schedule.getPetId());


all schedule manipulation (especially modifications) must be done in ScheduleService

mfarsikov · 2018-01-11T18:55:13Z

src/main/java/springee/schedule/ScheduleController.java

+        SortedMap<Integer, Integer> sortedSchedule = new TreeMap<>();
+        for (Schedule schedule: set) {
+            if(schedule.getDate().equals(date)) {
+                sortedSchedule.put(schedule.getTime(), schedule.getPetId());


try to rework it using Stream API

…ntroller class, removed logic for getting schedule in concrete day to ScheduleService class and rework it using Stream API.

1eonID added 4 commits November 27, 2017 08:50

HW from Lesson 5, create controller dor class Doctor and add CRUD met…

dd42bf4

…hods. Part 1.

HW from Lesson 5, update CRUD methods. Part 2.

565d784

HW from Lesson 5, update createDoctor method for POST request. Part 3.

a0110c8

HW from Lesson 5. Changed method for POST request in DoctorController…

b2d5927

… and PetController classes.

mfarsikov reviewed Nov 30, 2017

View reviewed changes

1eonID added 5 commits December 1, 2017 10:39

HW from Lesson 5. Changed method for POST request in DoctorController…

a025aaf

… and PetController classes. Avoid synchronization using non-blocking data type AtomicInteger.

HW from Lesson 5. Add synchronizedMap to Pet- and DocController classes.

458ed3d

HW from Lesson 6. Part 1. Create 3 layers of our app and divided Doct…

ffe148a

…orController class into Doctor, Controller, Service and Repository classes.

HW from Lesson 6. Part 2. Update Controller, Repository and Service c…

cd61921

…lasses.

HW from Lesson 6. Part 3. Create class DoctorConfig for working with …

6868280

…YAML config file and create methods getSpecializations and getSpecieList(in DoctorController class) for returning list of available specializations from application.yml file.

mfarsikov reviewed Dec 7, 2017

View reviewed changes

1eonID added 9 commits December 7, 2017 21:59

HW from Lesson 7. Part 1. Connected the database and saved doctors in…

5cd04a3

… PostgreSQL DB. Remove class DoctorRepository and implement JpaRepository for working with DB. Change some methods in DoctorController and DoctorService classes for correct working with JPA.

HW from Lesson 7. Part2. Change method update, for PUT requests. And …

e85d57b

…again - Remove class DoctorRepository and implement JpaRepository for working with DB. Change some methods in DoctorController and DoctorService classes for correct working with JPA.

HW from Lesson 7. Change query in method findNullebleByNameAndSpecial…

7ae648e

…ization, for searching name of doctor ignoring case.

HW from Lesson 8. Refactored package 'pet'. Add Schedule class, for d…

8ede858

…octor schedule. Add date converter. Some changes in config files.

HW from Lesson 8. Part 2. Refactored package 'doctor', edit sql query…

e999fe6

… for find method in JpaDoctorRepository interface. Change SpreengeeConfig.

HW from Lesson 8. Part 3. Edit class Schedule, method 'recordingToDoc…

96a61a6

…tor' in DoctorController class and update query in JpaDoctorRepository.

HW from Lesson 8. Part 4. Create package 'schedule' and create Reposi…

7e3f9d7

…tory, Service and Controller classes for Schedule. Refactor all classes in package 'doctor', for separating Doctor and Schedule entities.

HW from Lesson 8. Part 5. Create package 'validation', for separating…

f5f2a5c

… classes and methods with operations of validating from entities classes. Create 'dto' package and PetIdInputDto class for correct working with 'pet id' in Request Body.

mfarsikov reviewed Jan 11, 2018

View reviewed changes

HW from Lesson 8. Part 6. Refactored method getSchedule in ScheduleCo…

cbe7b52

…ntroller class, removed logic for getting schedule in concrete day to ScheduleService class and rework it using Stream API.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Home work #1

Home work #1

Uh oh!

1eonID commented Nov 30, 2017

Uh oh!

mfarsikov Nov 30, 2017 •

edited

Loading

Uh oh!

mfarsikov Dec 7, 2017

Uh oh!

mfarsikov Dec 7, 2017

Uh oh!

mfarsikov Dec 7, 2017

Uh oh!

mfarsikov Dec 7, 2017

Uh oh!

mfarsikov Jan 11, 2018

Uh oh!

mfarsikov Jan 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		private List<String> specializations = new ArrayList<>();

		public List<String> getSpecializations() {

Home work #1

Are you sure you want to change the base?

Home work #1

Uh oh!

Conversation

1eonID commented Nov 30, 2017

Uh oh!

mfarsikov Nov 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mfarsikov Dec 7, 2017

Choose a reason for hiding this comment

Uh oh!

mfarsikov Dec 7, 2017

Choose a reason for hiding this comment

Uh oh!

mfarsikov Dec 7, 2017

Choose a reason for hiding this comment

Uh oh!

mfarsikov Dec 7, 2017

Choose a reason for hiding this comment

Uh oh!

mfarsikov Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

mfarsikov Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mfarsikov Nov 30, 2017 •

edited

Loading