Skip to content

Conversation

@danfimov
Copy link
Member

@danfimov danfimov commented Dec 6, 2025

  • Fixed mypy issues in redis backend by passing arguments more explisitly to redis.set();
  • Muted mypy errors in ListScheduleSource (because it's look like problem with types on redis part). I can just use cast to Awaitable but it's basically the same as use ignore;
  • Muted warning about RedisScheduleSource in tests, because it's known issue and it's okey to have it. In my opinion - pytest results must be clean. If new warnings will be created - they should be fixed or ignored with a good reason.

Overall I just want to unblock work in #111 by making CI checks green at least on main.

@danfimov danfimov marked this pull request as ready for review December 6, 2025 10:00
Copilot AI review requested due to automatic review settings December 6, 2025 10:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix CI issues by addressing mypy type checking errors and pytest warnings. The changes focus on making type annotations more explicit and suppressing known deprecation warnings.

Key Changes

  • Refactored redis.set() calls to use explicit named parameters instead of **kwargs to resolve mypy type checking issues
  • Added # type: ignore comments to suppress mypy warnings in redis broker and list schedule source where type issues originate from the redis library
  • Added pytest warning filter to suppress known deprecation warnings about RedisScheduleSource

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
taskiq_redis/redis_broker.py Added type ignore comments for redis operations and updated type hints for additional_streams parameter
taskiq_redis/redis_backend.py Refactored redis.set() calls to use explicit parameters and removed unused Dict import; updated documentation comments
taskiq_redis/list_schedule_source.py Added type ignore comments for redis list operations
pyproject.toml Added pytest configuration to filter deprecation warnings for RedisScheduleSource

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danfimov danfimov merged commit 834b03b into main Dec 6, 2025
14 checks passed
@danfimov danfimov deleted the fix-issues-in-ci branch December 6, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants