uefi: add basic integration test for BlockIo and BlockIo2 protocols + fix in BlockIo2 #1842
+166
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately not discovered in the review.
phip1611
commented
Dec 6, 2025
| media_id: u32, | ||
| lba: Lba, | ||
| token: Option<NonNull<BlockIO2Token>>, | ||
| len: usize, |
Member
Author
There was a problem hiding this comment.
ping @Virv12 FYI. Unfortunately, I missed this in the review.
Contributor
There was a problem hiding this comment.
I don't like this change, using a reference introduces a lifetime, implying we are going to use the buffer only until the lifetime is alive, which is wrong.
There has been a similar discussion on DiskIO2.
Member
Author
There was a problem hiding this comment.
Thanks a lot for pointing that out to me, I wasn't aware of this anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add basic integration test for BlockIo and BlockIo2 protocols + fix in BlockIo2
Checklist