Merge pull request #447 from eregon/remove-continue-on-error-tests

Remove continue-on-error for "rake test" on truffleruby and skip problematic tests

Author: eregon

.github/workflows/test.yml

@@ -36,7 +36,6 @@ jobs:
 
       - name: Run tests
         run: rake test
-        continue-on-error: ${{ matrix.ruby == 'truffleruby' }}
 
   benchmark-default:
     runs-on: ubuntu-latest

Rakefile

@@ -6,7 +6,12 @@ desc 'Run all tests'
 Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
   t.libs << 'lib'
-  t.test_files = FileList['test/**/*_test.rb']
+  test_files = FileList['test/**/*_test.rb']
+  if RUBY_ENGINE == 'truffleruby'
+    # rmagick segfaults on truffleruby 25.0.0
+    test_files -= ['test/graph_renderer_test.rb']
+  end
+  t.test_files = test_files
   t.verbose = true
   t.warning = true
 end

test/benchmark_runner_cli_test.rb

@@ -33,8 +33,13 @@
 
   # Helper method to create args directly without parsing
   def create_args(overrides = {})
+    if RUBY_ENGINE == 'truffleruby'
+      executables = { 'truffleruby' => [RbConfig.ruby] }
+    else
+      executables = { 'interp' => [RbConfig.ruby], 'yjit' => [RbConfig.ruby, '--yjit'] }
+    end
     defaults = {
-      executables: { 'interp' => [RbConfig.ruby], 'yjit' => [RbConfig.ruby, '--yjit'] },
+      executables: executables,
       out_path: nil,
       out_override: nil,
       harness: 'harness',

test/benchmark_runner_test.rb

@@ -497,6 +497,7 @@
 
   describe '.render_graph' do
     it 'delegates to GraphRenderer and returns calculated png_path' do
+      skip 'rmagick segfaults on truffleruby 25.0.0' if RUBY_ENGINE == 'truffleruby'
       Dir.mktmpdir do |dir|
         json_path = File.join(dir, 'test.json')
         expected_png_path = File.join(dir, 'test.png')