(request) update map on frame

[GalvareyPoco]

is there a way to update also the map if it is on a frame? not only on your inventory

[quat1024]

I'm years late to responding to this (just cleaning out the issues). But this isn't possible because it's a clientside mod.

[quat1024]

Wait what the hell I'm stupid, this isn't a clientside mod.

[quat1024]

More thinking about this (since it was brought up on my discord too). In theory this isn't too hard; item frames tick, so from the tick method you'd inspect the item in the frame, grab its MapItemSavedData, and call the relevant method (MapItem#update). It takes a Player.

public void update(Level level, Entity entity, MapItemSavedData mapItemSavedData) {
  if (level.dimension() == mapItemSavedData.dimension && entity instanceof Player) {
    //...update the map...
  }
}

The trick is that Entity argument. You have to pass a Player, can't pass null, and map code uses their X and Z position to decide what part of the map to update. I guess it could be something simple: from the item frame, pick a random nearby player in the dimension and call the method on their behalf.

However I'm also concerned about performance. It's common for people to make gigantic map walls and I don't want to turn a field of 36 maps into 36 constantly updating maps since map updating is very expensive...

[EGOIST1372]

One question
why to do this tho?
item frame maps cant move on their own
so its best to not update the content of it
if player wants to update then they will bring map with themselves
this both looks not vanilla friendly and burden on performance by checking maps on item frames constantly
its a bad idea IMO
thanks in advance <3