Skip to content

Support message matching in death tests #16281

@rascani

Description

@rascani

🚀 The feature, motivation and pitch

In #16162, we added a variety of null pointer asserts and a corresponding set of death tests to ensure they are caught. An earlier revision of the the PR included message matchers for those assertions, but these all failed on Windows. The reason why was not immediately clear, but the default matcher for string literals is regex-based and there is different gtest regex parsing on posix systems than Windows & Mac.

It would be preferable to bring back the message matching and investigate why Windows failed. Having message matching would allow us to ensure that the right assert is firing.

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions