-
Notifications
You must be signed in to change notification settings - Fork 766
Open
Description
🚀 The feature, motivation and pitch
In #16162, we added a variety of null pointer asserts and a corresponding set of death tests to ensure they are caught. An earlier revision of the the PR included message matchers for those assertions, but these all failed on Windows. The reason why was not immediately clear, but the default matcher for string literals is regex-based and there is different gtest regex parsing on posix systems than Windows & Mac.
It would be preferable to bring back the message matching and investigate why Windows failed. Having message matching would allow us to ensure that the right assert is firing.
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
In progress