Address pandas-related upstream errors in #10973 #10988
Open
+50
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
commented
Dec 6, 2025
| ds2.plot.scatter(x="A", y="B", hue="hue") | ||
|
|
||
| ds2["hue"] = pd.timedelta_range("-1D", periods=4, freq="D") | ||
| ds2["hue"] = pd.timedelta_range("-1D", periods=4, freq="D", unit="ns") # type: ignore[call-arg,unused-ignore] |
Member
Author
There was a problem hiding this comment.
This type error has been fixed upstream, but we currently pin to an earlier version of pandas-stubs due to another issue: #10110.
dcherian
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the pandas-related upstream errors surfaced in #10973. I broke down the commits according to which pandas PR the errors resulted from. Most of these changes are explicitly specifying nanosecond units in test setups where those units were implied before.
Some other updates on the pandas side that we had to adapt to are that
datetime.timedeltaobjects are now converted to microsecond resolutionnp.datetime64values instead of nanosecond resolution, and the"mode.copy_on_write"option is being deprecated and will always be set toTrue.In the end, I think none of these changes were too concerning, and were in some ways helpful from a
CFTimeIndexperspective.Closes #10973
cc: @kmuehlbauer