Merge pull request #1162 from sanfrancrisko/IAC-1228/main/fix_up_r27_spec_failures

(IAC-1228) Fix multiple spec test issues in Ruby 2.7

Author: michaeltlombardi

spec/functions/load_module_metadata_spec.rb

@@ -7,6 +7,8 @@
 
   describe 'when calling with valid arguments' do
     before :each do
+      # In Puppet 7, there are two prior calls to File.read prior to the responses we want to mock
+      allow(File).to receive(:read).with(anything, anything).and_call_original
       allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}, :encoding => 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
       allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}).and_return('{"name": "puppetlabs-stdlib"}')
       # Additional modules used by litmus which are identified while running these dues to being in fixtures

spec/functions/loadjson_spec.rb

@@ -6,6 +6,8 @@
 
   describe 'when calling with valid arguments' do
     before :each do
+      # In Puppet 7, there are two prior calls to File.read prior to the responses we want to mock
+      allow(File).to receive(:read).with(anything, anything).and_call_original
       allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}, :encoding => 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
       allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}).and_return('{"name": "puppetlabs-stdlib"}')
       # Additional modules used by litmus which are identified while running these dues to being in fixtures

spec/functions/shell_escape_spec.rb

@@ -17,8 +17,8 @@
     it { is_expected.to run.with_params('foo').and_return('foo') }
     it { is_expected.to run.with_params('foo bar').and_return('foo\ bar') }
     it {
-      is_expected.to run.with_params('~`!@#$%^&*()_+-=[]\{}|;\':",./<>?')
-                        .and_return('\~\`\!@\#\$\%\^\&\*\(\)_\+-\=\[\]\\\\\{\}\|\;\\\':\",./\<\>\?')
+      is_expected.to run.with_params('~`!@#$%^&*()_-=[]\{}|;\':",./<>?')
+                        .and_return('\~\`\!@\#\$\%\^\&\*\(\)_-\=\[\]\\\\\{\}\|\;\\\':\",./\<\>\?')
     }
   end
 

spec/functions/shell_join_spec.rb

@@ -14,8 +14,8 @@
     it { is_expected.to run.with_params(['foo', 'bar']).and_return('foo bar') }
     it { is_expected.to run.with_params(['foo', 'bar baz']).and_return('foo bar\ baz') }
     it {
-      is_expected.to run.with_params(['~`!@#$', '%^&*()_+-=', '[]\{}|;\':"', ',./<>?'])
-                        .and_return('\~\`\!@\#\$ \%\^\&\*\(\)_\+-\= \[\]\\\\\{\}\|\;\\\':\" ,./\<\>\?')
+      is_expected.to run.with_params(['~`!@#$', '%^&*()_-=', '[]\{}|;\':"', ',./<>?'])
+                        .and_return('\~\`\!@\#\$ \%\^\&\*\(\)_-\= \[\]\\\\\{\}\|\;\\\':\" ,./\<\>\?')
     }
 
     context 'with UTF8 and double byte characters' do