From a03ff6b3c7c1c774e1fac25e638bbecd6e7ff89f Mon Sep 17 00:00:00 2001 From: Romain Lebbadi-Breteau Date: Mon, 20 Oct 2025 14:14:36 -0400 Subject: [PATCH] Change 'requires' to 'install_requires' in setup.py The runtime dependencies should be in "install_requires". "requires" is for build dependencies. Otherwise, the "requests" package won't correctly be installed when running "pip install python-powerdns" in a clean environment: ``` Python 3.10.12 (main, Aug 15 2025, 14:32:43) [GCC 11.4.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import powerdns Traceback (most recent call last): File "", line 1, in File "/home/romain/.../venv/lib/python3.10/site-packages/powerdns/__init__.py", line 26, in from .client import PDNSApiClient File "/home/romain/.../venv/lib/python3.10/site-packages/powerdns/client.py", line 27, in import requests ModuleNotFoundError: No module named 'requests' ``` Reference: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#declaring-required-dependency --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 880ce1b..42c8940 100644 --- a/setup.py +++ b/setup.py @@ -59,5 +59,5 @@ 'Environment :: Web Environment', 'Topic :: Utilities', ], - requires=['urllib3', 'requests'] + install_requires=['urllib3', 'requests'] )