Login: askPermissions() callback must die() by own

Author: milo

src/Github/OAuth/Login.php

@@ -67,11 +67,10 @@ public function askPermissions($backUrl, $redirectCb = NULL)
 		$url = $this->authUrl . '?' . http_build_query($params);
 		if ($redirectCb === NULL) {
 			header("Location: $url");
+			die();
 		} else {
 			call_user_func($redirectCb, $url);
 		}
-
-		die();
 	}
 
 

tests/Github/OAuth/Login.askPermissions.own.phpt

@@ -3,7 +3,7 @@
 /**
  * @author  Miloslav Hůla
  *
- * @outputMatch Was called
+ * @outputMatch Was called. Must die by own.
  */
 
 require __DIR__ . '/../../bootstrap.php';
@@ -17,7 +17,7 @@ $storage = new Milo\Github\Storages\SessionStorage;
 $login = new Milo\Github\OAuth\Login($config, $storage);
 $login->askPermissions('http://', function($url) {
 	Assert::match('https://github.com/login/oauth/authorize?client_id=i&redirect_uri=http%3A%2F%2F&scope=&state=%h%', $url);
-	echo "Was called";
+	echo "Was called. ";
 });
 
-throw new \Exception('Must not be there.');
+echo "Must die by own.";