Skip to content

tb_log_hist_steps is misplaced in the Tensorboard writer #77

@shatu

Description

@shatu

tb_log_hist_steps seems to be misplaced in the Tensorboard writer. A good design principle here in my opinion should be to just let the writer write out the logs, and control the frequency of writing through the stats and trainer/trainer_backend classes. This is already followed for other types of logging, and should be used consistently for writing out the histograms through tensorboard as well.

if step % self.args.tb_log_hist_steps == 0:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions