Why are the `Segments` methods private?

[mattfbacon]

I'm trying to understand the reasoning for this. Since they are private, I have to collect the path element iterator into a Vec, create BezPath, then call the method there, which turns the Vec to an iterator, gets Segments and calls the private method there.

[waywardmonkeys]

Is this about perimeter, area, winding, and bounding_box?

Those each have a comment // TODO: pub? Or is this subsumed by method of &[PathEl]?

Those are available via the Shape trait, which is implemented for &'a [PathEl], [PathEl; N], as well as PathSeg.

I think it is probably fine to make them pub rather than pub(crate), but it might be worth hearing more about what you're doing and how you ended up with Segments but not one of the other representations.

[mattfbacon]

I'm working on typst. But basically, an Iterator<Item = PathEl> is the most flexible compared to &[PathEl], [PathEl; N], or Vec<PathEl> (aka BezPath). Since the algorithms don't seem to require a slice, I would appreciate the flexibility of being able to use an iterator here.

I would expect that Segments<I> would implement Shape when I: Iterator<Item = PathEl>.

[mattfbacon]

So what do you think, can we change this?

[waywardmonkeys]

We're going to try to do a release of Kurbo this week (maybe today), so this might slip until the next, but if we have a consensus on this and it isn't a breaking change, then we should be able to roll a new release much more quickly (even this month).