Hostpath mount validation #4419
Open
+194
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Horiodino
force-pushed
the
hostPath_mount_validation
branch
from
75f0a14 to
84ff74e
Compare
AkihiroSuda
reviewed
Dec 1, 2025
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Horiodino
force-pushed
the
hostPath_mount_validation
branch
from
84ff74e to
c44939c
Compare
AkihiroSuda
reviewed
Dec 3, 2025
AkihiroSuda
reviewed
Dec 3, 2025
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Horiodino
force-pushed
the
hostPath_mount_validation
branch
from
57736fb to
6f59ab8
Compare
AkihiroSuda
reviewed
Dec 5, 2025
Member
There was a problem hiding this comment.
Tests are failing on Windows
Also please squash the commits
https://lima-vm.io/docs/dev/git/#squashing-commits
AkihiroSuda
reviewed
Dec 5, 2025
| } | ||
| if logs != "" { | ||
| callToolRes.Meta = map[string]any{ | ||
| "io.lima-vm/logs": []string{logs}, |
Member
There was a problem hiding this comment.
This should be defined as a constant
Member
There was a problem hiding this comment.
Suggested change
| "io.lima-vm/logs": []string{logs}, | |
| const MetaWarnings = "io.lima-vm.mcp/warnings" |
Member
There was a problem hiding this comment.
Also do not clear existing entries in Meta.
Such entries may not exist in the current code, but may appear in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
added validation to ensure
hostPathis part of a configured mount. if the path is not mounted, an error is returned.Testing:
added unit tests for
isMounted