Skip to content

Conversation

@p172913
Copy link

@p172913 p172913 commented Dec 2, 2025

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

macOS 13 support removed and updated macOS 13 to macOS 15 along with updated docs to macOS 14

Which issue(s) this PR fixes:
Fixes #21666

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?
None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None

@k8s-ci-robot
Copy link
Contributor

@p172913: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

macOS 13 support removed and updated macOS 13 to macOS 15 along with updated docs to macOS 14

Which issue(s) this PR fixes:
Fixes #21666

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?
None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p172913
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @p172913. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2025
@p172913
Copy link
Author

p172913 commented Dec 2, 2025

Squashing commit giving merger issue with others commits in the PR #21920. So created new PR.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nirs
Copy link
Contributor

nirs commented Dec 3, 2025

Squashing commit giving merger issue with others commits in the PR #21920. So created new PR.

Learning how to do interactive rebase and force push is very useful. Closing and opening new PR is not the way to rearrange your commits.

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI and documentation changes look good. The macOS version check should not change.

Please also rename the PR to something that reflect the actual change like "Drop macOS 13 support".


func virtualBoxMacOS13PlusWarning(driverName string) {
if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() {
func virtualBoxMacOS14PlusWarning(driverName string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we see the full picture, it is clear that we should not change the version we check. We log a warning about macOS 13 or later, so the this function and detect.MacOS13Plus do not need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for macOS 13

4 participants