-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Revoking MacOS 13 accesses #22027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Revoking MacOS 13 accesses #22027
Conversation
|
@p172913: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p172913 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @p172913. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Squashing commit giving merger issue with others commits in the PR #21920. So created new PR. |
|
Can one of the admins verify this patch? |
Learning how to do interactive rebase and force push is very useful. Closing and opening new PR is not the way to rearrange your commits. |
nirs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI and documentation changes look good. The macOS version check should not change.
Please also rename the PR to something that reflect the actual change like "Drop macOS 13 support".
|
|
||
| func virtualBoxMacOS13PlusWarning(driverName string) { | ||
| if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() { | ||
| func virtualBoxMacOS14PlusWarning(driverName string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we see the full picture, it is clear that we should not change the version we check. We log a warning about macOS 13 or later, so the this function and detect.MacOS13Plus do not need to change.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
macOS 13 support removed and updated macOS 13 to macOS 15 along with updated docs to macOS 14
Which issue(s) this PR fixes:
Fixes #21666
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None