Skip to content

Missing AccessMode validation under certain conditions #2217

@sunnylovestiramisu

Description

@sunnylovestiramisu

We pass in empty accessMode for disk insert request in the code.

Seems like we will reach the empty accessModes under the following conditions:

  • The disk type specified in the parameters.DiskParameters is not a Hyperdisk.
  • AND either of the following is true:
    1. The volume is not requested as readonly.
    2. The disk type is not a type that supports modifiable access modes (e.g., not hyperdisk-ml).

We should not trigger a disk insert call in this case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions