Skip to content
This repository was archived by the owner on Dec 21, 2019. It is now read-only.
This repository was archived by the owner on Dec 21, 2019. It is now read-only.

getters.border returns null #11

@arian

Description

@arian

See https://github.com/kamicane/moofx/blob/master/lib/browser.js#L317

This makes sense if you want to get the border property. However when animating the border, when one border (for example the top) is different, it will return null which causes an error here: https://github.com/kamicane/moofx/blob/master/lib/browser.js#L567 (because null doesn't have a replace method).

I think when it's detected that the borders are different, it should change

{
     border: '1px solid red'
}
// into
{
     borderTop: '1px solid red',
     borderRight: '1px solid red',
     borderBottom: '1px solid red',
     borderLeft: '1px solid red'
}

so all borders do animate to the desired value, and it would prevent the error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions