Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.
This repository was archived by the owner on May 28, 2025. It is now read-only.

importing __version__ from jss prevents pip install from working with pre-installing requirements #100

@pboushy

Description

@pboushy

If you try to install python-jss from source using pip install, you get several errors that you need to install six, requests, etc.

pip is capable of installing these dependencies for python-jss, but can't because setup.py is trying to import jss and failing on the dependencies (chicken and the egg scenario)

There are multiple ways to solve this:

  1. set the version in setup.py
  2. Choose one of the methods for single-sourcing-the-version listed https://packaging.python.org/guides/single-sourcing-package-version/#single-sourcing-the-version

By doing this it will simplify the installation of python-jss.

After some discussion on this, I'm glad to submit a pull request for the change.

Personally, since the version isn't used anywhere except setup.py currently, I'd recommend we set it statically in setup.py, and can revisit that in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions