Skip to content

Should the SlotsProvider set PAGE level targeting? #204

@patrick-mcdougle

Description

@patrick-mcdougle

I was browsing through the codebase and I noticed the only way to set page level targeting (on the pubads service directly) is to use the function on the manager. IMO the slots provider would be a good place to set PAGE level targeting and the slot to be a good place to set SLOT targeting? What would you think of this change? Since we're doing manual merging in the slot today, I don't think this would be a bc break, it would just use the appropriate functions of the GPT library (and reduce the amount of merging you have to do manually)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions