Adams stellar distribution has non monotonous and dublicate distances for LMC+SMC

[jakob2508]

I am trying to plot the distribution of CCSNe in the Galaxy and the LMC+SMC using the Adams et al. 2013 data in /data/stellar/. Below is a minimal example. I find duplicate values for the distance (e.g. 60 kpc) and a non-monotonous array for the distances. After 62.5 kpc the distances jump back to 53.75 kpc.

from asteria.stellardist import StellarDensity

distribtion = StellarDensity("path/to/asteria/data/stellar/sn_radial_distrib_adams.fits", add_LMC=True, add_SMC=True)

dist = distribtion.dist
cdf = distribtion.cdf

plt.plot(dist, cdf)
plt.xlim(50,66) # zoom in on the jump
plt.ylim(0.97,1)
plt.xlabel("distance")
plt.ylabel("cdf")

I also noticed that the paper does not show any probability beyond the edge of the Milky Way. How is the LMC+SMC data provided in ASTERIA?

[jakob2508]

LMC and SMC are added as simple Gaussians in stellardist.py in the __init__ of the StellarDensity class. At the moment, there are no guardrails in place when both LMC and SMC are requested and have overlapping values. Some sort of envelope function needs to be applied, duplicates removed, and the distance re-sorted.