-
Notifications
You must be signed in to change notification settings - Fork 954
Intel DeepMath blog #3180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel DeepMath blog #3180
Conversation
|
Waiting on PR for assets in documentation-images: https://huggingface.co/datasets/huggingface/documentation-images/discussions/572. |
7d2d64c to
4d2d301
Compare
|
Assets moved to |
echarlaix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition @danielfleischer, left couple of comments
faf05e2 to
fb31c0b
Compare
|
Thank you for the review! I addressed all issues; dark-mode friendly illustration is pending PR at https://huggingface.co/datasets/huggingface/documentation-images/discussions/573/files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for iterating, added couple of comments on the content
|
Thank you for the feedback, we've made changes: added references, background, better explanation of results table, as well as other points made. |
echarlaix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left couple of minor comments
|
Thanks for all reviewers! |
|
Thanks for merging! @echarlaix I noticed the title has SmolAgents, and after all the lowercasing in the blog, is it OK? |
|
@danielfleischer let me know if you have time to take care of this and I will take care of merging it asap no problem! |
|
@echarlaix Sure; just |
Code: https://github.com/intellabs/DeepMath
Model: https://huggingface.co/Intel/deepmath-v1
Preparing the Article
mdfile. You can also specifyguestororgfor the authors.Here is an example of a complete PR: #2382