Skip to content

Conversation

@Lutra-Fs
Copy link
Collaborator

@Lutra-Fs Lutra-Fs commented Aug 9, 2024

Pull Request Details

What issue does this PR address

image
image

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the style and coding guideline
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Pre-exisiting lint errors noted:
    warning - Unused import: 'package:rattle/r/start.dart' - lib\app.dart:36:8 - unused_import
    warning - The value of the local variable 'stdout' isn't used - lib\features\visual\display.dart:53:12 - unused_local_variable
  • Tested on at least one device
    • Android Phone
    • Android Emulator
    • Chrome on Android
    • Chrome
    • iOS
    • Linux
    • MacOS
    • Windows
  • Added a reviewer

Finalising

Once PR discussion is complete and reviewer has approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Add one line summary into CHANGELOG.md
  • Bump appropriate version number in pubspec.yaml
  • Push to git repository and review
  • Merge PR into dev (gjwgit)

@Lutra-Fs Lutra-Fs force-pushed the fix-windows-connection branch from ed67610 to 3a9a774 Compare August 9, 2024 05:40
Copy link
Owner

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gjwgit gjwgit merged commit c7b9cdf into gjwgit:dev Aug 9, 2024
@Lutra-Fs Lutra-Fs deleted the fix-windows-connection branch August 9, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] failed to install pacman in RattleNG R Console

2 participants