Disable npm lifecycle scripts and npx for security #71
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Dockerfile with ignore-scripts configuration for npm/yarn - Disable npx with informative error message - Update devcontainer.json to use the new Dockerfile Fixes PDE-183 Co-authored-by: Ona <no-reply@ona.com>
jespino
force-pushed
the
jesus/pde-183-disable-npm-lifecycle-scripts-in-gitpod-sdk-typescript
branch
from
481ec5c to
f98e706
Compare
geropl
reviewed
Dec 8, 2025
geropl
reviewed
Dec 8, 2025
.devcontainer/Dockerfile
Outdated
| echo 'ignore-scripts true' >> ~/.yarnrc | ||
|
|
||
| # Disable npx for security | ||
| RUN rm -f /usr/bin/npx /usr/local/bin/npx && \ |
Member
There was a problem hiding this comment.
We could use $(which npx) to make this more reliable across repos
Contributor
Author
There was a problem hiding this comment.
I'm updating this here, and in other PRs
geropl
requested changes
Dec 8, 2025
Replace hardcoded /usr/bin/npx and /usr/local/bin/npx with $(which npx) to handle different npx installation locations. Co-authored-by: Ona <no-reply@ona.com>
…in-gitpod-sdk-typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable npm/yarn lifecycle scripts and npx in the devcontainer for security.
Changes
.devcontainer/Dockerfilewith security configurations.devcontainer/devcontainer.jsonto use the new DockerfileSecurity configurations
npm config set ignore-scripts true- disables npm lifecycle scriptsignore-scripts truein.yarnrc- disables yarn lifecycle scriptsFixes PDE-183