chore(data-forwarding): Allow clearing empty overrides, examples for endpoints, typo #104479
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| config = serializers.DictField( | ||
| child=serializers.CharField(allow_blank=True), | ||
| default=dict, | ||
| help_text="The configuration for the data forwarder.", |
There was a problem hiding this comment.
is there a place people can look for what to put in this field?
There was a problem hiding this comment.
That's a good call, I can try just throwing all the data in here but its a bit cumbersome. For now I think it's okay to leave it vague, I included all of the fields with realistic data for examples so hopefully if someone really does wanna do this via API it works alright
This PR adds a clear overrides button. Therefore projects can have an empty value where there was once a value if they choose (i.e. global has "some-value", override has "", which is different than no override)
Also edits a typo on the SQS form, and adds modifies some examples with realistic payloads.