-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(triage signals): Seer orgs on new pricing need to have Github integration to use autofix #104477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mihir-Mavalankar
wants to merge
6
commits into
master
Choose a base branch
from
github-connected-repos-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−2
Open
feat(triage signals): Seer orgs on new pricing need to have Github integration to use autofix #104477
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
319461a
feat(triage signals): Seer orgs on new pring need to have Github inte…
Mihir-Mavalankar 050df12
fixed tests
Mihir-Mavalankar 02f768c
removed import
Mihir-Mavalankar c245e5d
removed import
Mihir-Mavalankar 6be5430
circular import
Mihir-Mavalankar 5cf1c73
Merge branch 'master' into github-connected-repos-check
Mihir-Mavalankar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: API failure after cache lock causes missed automation
The
has_project_connected_reposcheck is placed aftercache.add(automation_dispatch_cache_key, ...)on line 1688, which atomically blocks duplicate dispatches. If the Seer API call inhas_project_connected_reposraises aSeerApiError(as the testtest_raises_on_api_errorconfirms it can), the exception propagates but the cache key remains set for 5 minutes. This blocks any subsequent automation dispatch attempts for that group, even though no automation was actually dispatched. The repo check should happen before the cache lock to avoid this scenario.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The risk is acceptable IMO. Keeping outside the lock means a lot more volume to the API endpoint which we want to avoid.
If it fails because of an API error automation will be re-tried after 5 minutes when new events come.