[FR] Argument to disable "Done formatting"

[jack-bradshaw]

Please consider adding an argument that suppresses the "Done formatting" println each time a file is formatted. In very large repositories it gets printed a lot. Also side note, the incremental updates actually get written to std error, not std out, which is odd.

[hick209]

That actually does seem like a good idea. Feel free to put a PR for it

[KaranPradhan266]

Hi @hick209 — I’m happy to take this on. Quick clarification on expected behavior before I start:
would printing a single “Done formatting” message per run (instead of per file) be sufficient, or is the intent to suppress it entirely behind a CLI flag?
I’m leaning toward implementing this behind a flag, but wanted to confirm your preference first.

[hick209]

@jack-bradshaw, as a short term solution what if you just ignore the logs from stderr?

ktfmt 2>/dev/null <FILES>

@KaranPradhan266 I was thinking about a --quiet flag that would only print out error messages. WDYT?

[jack-bradshaw]

That's basically what I ended up doing

https://github.com/jack-bradshaw/monorepo/blob/main/first_party/formatting/ktfmtwrapper/KtFmtWrapper.java

[hick209]

Why not just use simple if guard statements in the prints?

[KaranPradhan266]

@hick209 I agree that the --quiet flag makes sense. I’ll raise a PR for this soon.