add getShortName() method to ResourceRecord class?

[mvdgeijn]

Hi,

I've created a new getShortName() method to the ResourceRecord class. It removes the domain name from the returned name. It returns @ if the name is empty.

Can I create a pull request for this? Or is this new method not accepted?

Kind regards,
Marc

    /**
     * Get the name of the resource record without the domain name.
     * Sets an empty string to @.
     *
     * @return string
     */
    public function getShortName(): string
    {
        $name = substr( $this->name, 0, -( strlen( $this->zone->getCanonicalName() ) + 1 ) );

        if( strlen( $name ) == 0 )
            $name = "@";

        return $name;
    }

[robbinjanssen]

Hi Marc,

Great idea, go ahead! 👍

[robbinjanssen]

Another way to go would be to add a $shortName = false param to the getName() method. Both are fine :-)

[trizz]

To prevent getting unclear booleans I prefer the ->getShortName() method instead of only ->getName(true).

[robbinjanssen]

@mvdgeijn let's keep it separated then and create a new method called getShortName as you suggested :)

[mvdgeijn]

@trizz @robbinjanssen, I created the pull request before reading these last 2 comments. I'll close the pull request and add the getShortName as suggested.

[trizz]

Added and released in v4.2.0.