From 4b33771cb9010e7bf71fd8cefa93c56cc5c8f418 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Mon, 12 Jan 2026 01:49:57 +0530 Subject: [PATCH] Update tests bird watcher --- .../src/test/java/BirdWatcherTest.java | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java b/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java index 5b1746082..2542b7658 100644 --- a/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java +++ b/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java @@ -1,26 +1,27 @@ +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; -import org.junit.jupiter.api.BeforeEach; -import static org.assertj.core.api.Assertions.*; +import static org.assertj.core.api.Assertions.assertThat; public class BirdWatcherTest { - private static final int DAY1 = 0; - private static final int DAY2 = 2; - private static final int DAY3 = 5; - private static final int DAY4 = 3; - private static final int DAY5 = 7; - private static final int DAY6 = 8; - private static final int TODAY = 4; + private static final int DAY1 = 7; + private static final int DAY2 = 0; + private static final int DAY3 = 4; + private static final int DAY4 = 8; + private static final int DAY5 = 5; + private static final int DAY6 = 2; + private static final int TODAY = 3; private BirdWatcher birdWatcher; - private final int[] lastWeek = {DAY1, DAY2, DAY3, DAY4, DAY5, DAY6, TODAY}; + private final int[] currentWeek = {DAY1, DAY2, DAY3, DAY4, DAY5, DAY6, TODAY}; + private final int[] lastWeek = {0, 2, 5, 3, 7, 8, 4}; @BeforeEach public void setUp() { - birdWatcher = new BirdWatcher(lastWeek); + birdWatcher = new BirdWatcher(currentWeek); } @Test @@ -28,7 +29,7 @@ public void setUp() { @DisplayName("The getLastWeek method correctly returns last week's counts") public void itTestGetLastWeek() { assertThat(birdWatcher.getLastWeek()) - .containsExactly(DAY1, DAY2, DAY3, DAY4, DAY5, DAY6, TODAY); + .isEqualTo(lastWeek); } @Test @@ -42,13 +43,16 @@ public void itTestGetToday() { @Tag("task:3") @DisplayName("The incrementTodaysCount method correctly increments today's counts") public void itIncrementTodaysCount() { + int firstSixDaysBeforeIncrement = birdWatcher.getCountForFirstDays(6); birdWatcher.incrementTodaysCount(); + int firstSixDaysAfterIncrement = birdWatcher.getCountForFirstDays(6); assertThat(birdWatcher.getToday()).isEqualTo(TODAY + 1); + assertThat(firstSixDaysAfterIncrement).isEqualTo(firstSixDaysBeforeIncrement); } @Test @Tag("task:4") - @DisplayName("The hasDayWithoutBirds method returns true when day had no visits") + @DisplayName("The hasDayWithoutBirds method returns true when at least one day had no visits") public void itHasDayWithoutBirds() { assertThat(birdWatcher.hasDayWithoutBirds()).isTrue(); } @@ -88,7 +92,7 @@ public void itTestGetCountForMoreDaysThanTheArraySize() { @Tag("task:6") @DisplayName("The getBusyDays method returns the correct count of busy days") public void itTestGetCountForBusyDays() { - // DAY3, DAY5 and DAY6 are all >= 5 birds + // DAY1, DAY4 and DAY5 are all >= 5 birds assertThat(birdWatcher.getBusyDays()).isEqualTo(3); }