igir not copying ROM unless `extract` is used

[alienth]

Paste the command

npx -x igir@latest copy --dat /tmp/dat --input /tmp/a --output /tmp/out

Describe the bug

I have an ISO which is zipped. The zip's header info has a CRC and size matching an entry in a dat. When I use igir copy with that zip and dat specified, no match occurs and a report indicates that the zip is UNUSED. When I use igir copy extract, a match does occur and the ISO is copied to the target.

I do encounter this same problem on other zipped ISOs. I just narrowed it to a single example to simplify.

I also unzipped and rezipped the ISO with a different utility, just in case there was some issue with the original zip's header preventing igir from looking at the checksum. Doing so did not resolve the issue.

Expected behavior

I expect igir to appropriately match and copy the zip without needing extract.

Debug logs

igir.log

DAT(s) used

No response

igir version

4.2.0

Node.js version

20.19.4

Operating system

ubuntu

Additional context

I originally encountered this on a Redump dat, but to simplify things and remove variables I modified the dat to only include a single entry:

<?xml version="1.0"?>
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
<datafile>
        <header>
                <name>Nintendo - GameCube</name>
                <version>2025-09-19 15-42-28</version>
                <date>2025-09-19 15-42-28</date>
                <author>redump.org</author>
                <homepage>redump.org</homepage>
                <url>http://redump.org/</url>
        </header>
        <game name="007 - Nightfire (USA)">
                <category>Games</category>
                <description>007 - Nightfire (USA)</description>
                <rom name="007 - Nightfire (USA).iso" size="1459978240" crc="737977cf" md5="a824f5a7a553b7598592c6c129378
262" sha1="7275e43f04caa3c9ec6f3675a54d043d4c544bf3"/>
        </game>
</datafile>

Here's the info from the zip header:

 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
1459978240  Defl:X 1340889980   8% 1996-12-24 23:32 737977cf  007 - Nightfire (2002)(Electronic Arts)(US).iso

[alienth]

I found the issue. It's because the filename contained within the zip does not match the filename from the dat. That scenario runs afoul of this check:

igir/src/modules/candidates/candidateGenerator.ts

Lines 234 to 237 in 7f9fe95

	// The input file is an ArchiveEntry that we won't rewrite and its name doesn't match
	// what we want it to be
	return false;
	}

This is somewhat surprising as the ROM Matching docs for igir state that matching occurs based upon checksum and size - I can't find any mention of archive contents needing to have matched filenames. I guess this isn't exactly a bug because the code clearly intends to do this, but from a functionality perspective it does feel surprising.

[alienth]

Random thought: It might be nice to add trace logging for those exclusion cases so that it's easier to discover this sort of thing.