-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
client:coreIssues relating to the JavaScript client SDKIssues relating to the JavaScript client SDKhelp wantedCommunity contributions are welcome.Community contributions are welcome.
Description
Is your feature request related to a problem? Please describe.
We have two related types (as I believe table columns are derived from the annotation data):
cube/packages/cubejs-client-core/src/types.ts
Lines 18 to 27 in 0fde75d
| export type Annotation = { | |
| title: string; | |
| shortTitle: string; | |
| type: string; | |
| meta?: any; | |
| format?: 'currency' | 'percent' | 'number'; | |
| drillMembers?: any[]; | |
| drillMembersGrouped?: any; | |
| granularity?: GranularityAnnotation; | |
| }; |
cube/packages/cubejs-client-core/src/types.ts
Lines 304 to 313 in 0fde75d
| export type TableColumn = { | |
| key: string; | |
| dataIndex: string; | |
| meta?: any; | |
| type: string | number; | |
| title: string; | |
| shortTitle: string; | |
| format?: any; | |
| children?: TableColumn[]; | |
| }; |
I'm wondering why the types for type and format are different? I feel like Annotation is the correct one?
Describe the solution you'd like
Update the TableColumn type to better match Annotation.
Describe alternatives you've considered
N/A
Additional context
N/A
Metadata
Metadata
Assignees
Labels
client:coreIssues relating to the JavaScript client SDKIssues relating to the JavaScript client SDKhelp wantedCommunity contributions are welcome.Community contributions are welcome.