Fix LUA healthcheck in ArgoCD guide #1023
Merged
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Jonasz Lasut-Balcerzak <jonasz.lasut@gmail.com>
jonasz-lasut
force-pushed
the
crossplane#6569-fix-argocd-healthcheck
branch
from
446b13c to
f61b4ff
Compare
jeanduplessis
approved these changes
Nov 21, 2025
Collaborator
jeanduplessis
left a comment
jeanduplessis
left a comment
There was a problem hiding this comment.
Thank you @jonasz-lasut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crossplane/crossplane#6569 after the healthcheck is implemented and used in ArgoCD as a default healthcheck for XP resources.
Early return in status.condition if condition.type is Ready and condition.status == "True" has led to ArgoCD incorrectly notyfing about status of MRs if the state has changed from healthy to unhealthy for example during spec.forProvider change that would lead to recreation of the MR
ArgoCD health status without the fix:
ArgoCD health status with the fix:
