Skip to content

Dont purge all the flows to aquila everytime #771

@Knerio

Description

@Knerio

Currently we just pass in all the flows:

message FlowResponse {
  oneof data {
    // Updates a single flow
    shared.ValidationFlow updated_flow = 1;
    // Deletes a single flow
    int64 deleted_flow_id = 2;
    // Replaces all flows in Aquila (only on startup and for releases)
    shared.Flows flows = 3; // We pass all flows, also if we only update one flow in here
  }
}

https://github.com/code0-tech/tucana/blob/5fa6b02ed70c70b326390b30bda89c3d22e31ca3/proto/sagittarius/sagittarius.flow.proto#L21

but when we are updating we should pass the updated flow(s) in here

message FlowResponse {
  oneof data {
    // Updates a single flow
    shared.ValidationFlow updated_flow = 1; // We should pass flow updates here
    // Deletes a single flow
    int64 deleted_flow_id = 2;
    // Replaces all flows in Aquila (only on startup and for releases)
    shared.Flows flows = 3;
  }

https://github.com/code0-tech/tucana/blob/5fa6b02ed70c70b326390b30bda89c3d22e31ca3/proto/sagittarius/sagittarius.flow.proto#L17

This isnt an issue but we should still fix that

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions