Skip to content

Conversation

@kamil-homer
Copy link

@kamil-homer kamil-homer commented Dec 7, 2025

Description

undefined values caused the UI element to be displayed as an empty block.

before:
Zrzut ekranu 2025-12-7 o 12 59 27

after:
Zrzut ekranu 2025-12-7 o 13 25 43

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Expanded Polish language support with comprehensive translations for organization management features, including organization creation and selection workflows, API key management, organization switching, and account recovery flows.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

🦋 Changeset detected

Latest commit: 6ffaaea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 7, 2025

@kamil-homer is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

A changeset entry documents the addition of Polish translations for Organizations-related UI elements in the localization file. Multiple previously undefined or placeholder translation strings are replaced with concrete Polish text across organization-related and task-choice screens.

Changes

Cohort / File(s) Summary
Changeset documentation
.changeset/whole-bikes-dig.md
Patch changeset entry recording Polish translation additions for Organizations UI elements.
Polish localization updates
packages/localizations/src/pl-PL.ts
Replaces undefined and placeholder translations with concrete Polish strings across organizationList, organizationProfile.apiKeysPage, organizationSwitcher, taskChooseOrganization, and taskResetPassword sections. Updates include organization creation labels, API key page titles, action buttons, form placeholders, and sign-out text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify Polish translation accuracy and consistency with existing translation patterns
  • Confirm all placeholder keys have been properly populated with appropriate localized strings
  • Check for any missing translations in related organization or task-choice sections

Poem

🐰 Polish words now bloom so bright,
Organizacje shine in light,
From "undefined" to "Słowa Prawdy"—
Our translations flow like waterfalls,
Hopping through locales with glee! 🌍✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding missing Polish translations to fix undefined UI elements in the localization file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2a508d3 and 6ffaaea.

📒 Files selected for processing (2)
  • .changeset/whole-bikes-dig.md (1 hunks)
  • packages/localizations/src/pl-PL.ts (3 hunks)
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Prefer importing types from @clerk/shared/types instead of the deprecated @clerk/types alias

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/pl-PL.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/pl-PL.ts
packages/localizations/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

packages/localizations/**: Localization support must include translations for 30+ languages using a modular localization system
Support RTL languages in the localization system

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/pl-PL.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (8)
.changeset/whole-bikes-dig.md (2)

1-5: Changeset format looks good.

The changeset metadata is properly formatted with appropriate bump level (patch) for translation additions.


5-5: Verify the actual Polish translations were applied to the locale file.

The changeset documents translation updates for Polish in Organizations UI elements, but direct verification of the locale file is needed to confirm the translations for organizationList, organizationProfile, organizationSwitcher, taskChooseOrganization, and taskResetPassword have been properly added. Check the Polish locale file (typically pl.json or similar in locales/ or translations/ directories) for the expected translation keys and their Polish values.

packages/localizations/src/pl-PL.ts (6)

267-273: LGTM! Consistent terminology and proper interpolation.

The translations correctly fill in missing values and improve consistency by using "Utwórz" (used throughout the file) instead of "Stwórz". The interpolation variable {{applicationName}} is properly preserved.


279-279: LGTM! Consistent with existing API key terminology.

The translation "Klucze API" aligns with the existing terminology used elsewhere in the file.


498-503: LGTM! Proper UI action labels.

The translations for close/open actions and the suggestions accept label are consistent with similar strings throughout the file (e.g., line 269, 855).


853-858: LGTM! Comprehensive organization choice translations.

The translations are consistent with the organizationList section and provide complete UI strings for the organization selection flow.


861-872: LGTM! Proper form labels and interpolation.

The form translations are consistent with existing patterns, and the interpolation variable {{identifier}} is correctly preserved in the sign-out strings.


876-881: LGTM! Complete password reset translations.

The translations provide complete strings for the password reset flow with proper interpolation variable preservation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants