-
Notifications
You must be signed in to change notification settings - Fork 362
Description
The idea of the features --output-check-record and --output-check are valid and we have today a few use cases that explore those functionalities.
The "problem" with this logic is that it is being used also to generate the test-results/stdout, stderr, and output files, depending on the --output-check-record value. I can understand that we are using this logic today because we are limited by the subprocess.Popen() ability to generate both "combined" and "split" (stdout and stderr) and also to avoid calling the tests twice.
We could split this logic into 3:
-
Sometimes the users would like to run the avocado only to generate the ".data/" folder with stdout, stderr, and combined results. For this situation we could have a boolean option named
--record-outputand the code can be executed twice to accomplish that. This run is something like a "dry-run" and there is no need to save information on job-results folder; -
A normal run that MUST be executed only once that will generate the job-results information and will not care about the
--record-output -
A run that will check for the expected values stored inside
.data/. This could be done with something like--check-output, also a boolean variable that will use the same logic that we have today:
3.1 If output.expected is there, then run the subprocess generating a "combined" version;
3.2 if stdout.expected or stderr.expected are there, then run the subprocess generating a "both/split" version;
@clebergnu any comments?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status