Merge pull request #2426 from jrochkind/render_inline_nokogiri_contextless

using context:'template' for Nokogiri::HTML5.fragment allows parsing of otherwise illegal fragments like <td>

Author: joelhawksley

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 6
 
 ## main
 
+* Allow `render_inline` with Nokogiri::HTML5 to parse more arbitrary content including bare table content otherwise illegal fragments like `<td>`.
+
+    *Jonathan Rochkind*
+
 * Remove known issue from docs as ActiveScaffold is [now compatible](https://github.com/activescaffold/active_scaffold/pull/743) with ViewComponent.
 
     *David Löwenfels*

lib/view_component/test_helpers.rb

@@ -40,7 +40,7 @@ def render_inline(component, **args, &block)
       @page = nil
       @rendered_content = vc_test_view_context.render(component, args, &block)
 
-      fragment = Nokogiri::HTML5.fragment(@rendered_content)
+      fragment = Nokogiri::HTML5.fragment(@rendered_content, context: "template")
       @vc_test_view_context = nil
       fragment
     end

test/sandbox/app/components/table_contents_component.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class TableContentsComponent < ViewComponent::Base
+  def call
+    "<td>td contents</td>".html_safe
+  end
+end

test/sandbox/test/rendering_test.rb

@@ -20,7 +20,7 @@ def test_render_inline_allocations
     MyComponent.__vc_ensure_compiled
 
     with_instrumentation_enabled_option(false) do
-      assert_allocations({"3.5" => 67, "3.4" => 72..74, "3.3" => 72, "3.2" => 75..76}) do
+      assert_allocations({"3.5" => 67, "3.4" => 72..74, "3.3" => 75, "3.2" => 78..79}) do
         render_inline(MyComponent.new)
       end
     end
@@ -34,7 +34,7 @@ def test_render_collection_inline_allocations
     ViewComponent::CompileCache.cache.delete(ProductComponent)
     ProductComponent.__vc_ensure_compiled
 
-    allocations = {"3.5" => 66, "3.4" => 70..82, "3.3" => 86, "3.2" => 89..90}
+    allocations = {"3.5" => 66, "3.4" => 70..82, "3.3" => 89, "3.2" => 92..93}
 
     products = [Product.new(name: "Radio clock"), Product.new(name: "Mints")]
     notice = "On sale"
@@ -77,6 +77,10 @@ def test_render_inline_returns_nokogiri_fragment
     assert_includes render_inline(MyComponent.new).css("div").to_html, "hello,world!"
   end
 
+  def test_render_inline_handles_table_contents
+    assert_includes render_inline(TableContentsComponent.new).css("td").to_html, "<td>td contents</td>"
+  end
+
   def test_render_inline_sets_rendered_content
     render_inline(MyComponent.new)