[bug] Always true condition in Pyramid

[zeddie888]

lost/src/star-id.cpp

Line 63 in 2d94a69

if (!votedInPair[*k] || true) {

@markasoftware This branch will always execute, is this intended behavior?

[markasoftware]

This is geometric voting, not pyramid. I'll take a closer look later but I think the ||true probably should be removed. But I think there's an argument either way, really. If a star is found multiple times here, in some sense it is truly higher probability to be the correct star, which supports the ||true. but I can see there being some weird starvation effects where if one star is the same distance from many other stars, it will always be selected when that distance pops up, which is an argument against the ||true. If you're actually using geometric voting I'd do some empirical tests to see what's best