Visual Overhaul causing runtime error with Modern Industrialization on Neoforge 1.21.1

[edumalves]

Hello and first of all thank you for you work on this mod. It's really appreciated.

When running visual overhaul together with modern industrialization (tested with the latest 2.3.3 version, not able to check if it applies to earlier versions), the client is disconnected with a runtime error every time the player clicks on any MI machine. The error is below:

[22Apr2025 05:40:06.570] [Render thread/ERROR] [net.neoforged.neoforge.network.handlers.ClientPayloadHandler/]: Failed to handle advanced open screen from server.
java.lang.NullPointerException: Cannot invoke "java.util.function.Supplier.get()" because "this.tooltipSupplier" is null
	at TRANSFORMER/modern_industrialization@2.3.3/aztech.modern_industrialization.machines.gui.MachineScreen$MachineButton.getMessage(MachineScreen.java:352) ~[Modern-Industrialization-2.3.3.jar%23501!/:?]
	at TRANSFORMER/visualoverhaul@5.2.1/eu.midnightdust.visualoverhaul.IconicButtons.init(IconicButtons.java:27) ~[visualoverhaul-neoforge-5.2.1.jar%23559!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.gui.components.AbstractButton.handler$dih000$visualoverhaul$iconic$onInitButton(AbstractButton.java:1023) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.gui.components.AbstractButton.<init>(AbstractButton.java:25) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.gui.components.Button.<init>(Button.java:29) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/modern_industrialization@2.3.3/aztech.modern_industrialization.machines.gui.MachineScreen$MachineButton.<init>(MachineScreen.java:343) ~[Modern-Industrialization-2.3.3.jar%23501!/:?]
	at TRANSFORMER/modern_industrialization@2.3.3/aztech.modern_industrialization.machines.gui.MachineScreen.addButton(MachineScreen.java:138) ~[Modern-Industrialization-2.3.3.jar%23501!/:?]
	at TRANSFORMER/modern_industrialization@2.3.3/aztech.modern_industrialization.machines.gui.MachineScreen.addLockButton(MachineScreen.java:156) ~[Modern-Industrialization-2.3.3.jar%23501!/:?]
	at TRANSFORMER/modern_industrialization@2.3.3/aztech.modern_industrialization.machines.gui.MachineScreen.init(MachineScreen.java:101) ~[Modern-Industrialization-2.3.3.jar%23501!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.gui.screens.Screen.init(Screen.java:317) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.Minecraft.setScreen(Minecraft.java:1057) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/neoforge@21.1.148/net.neoforged.neoforge.network.handlers.ClientPayloadHandler.lambda$createMenuScreen$0(ClientPayloadHandler.java:129) ~[neoforge-21.1.148-universal.jar%23374!/:?]
	at java.base/java.util.Optional.ifPresent(Optional.java:178) ~[?:?]
	at TRANSFORMER/neoforge@21.1.148/net.neoforged.neoforge.network.handlers.ClientPayloadHandler.createMenuScreen(ClientPayloadHandler.java:126) ~[neoforge-21.1.148-universal.jar%23374!/:?]
	at TRANSFORMER/neoforge@21.1.148/net.neoforged.neoforge.network.handlers.ClientPayloadHandler.handle(ClientPayloadHandler.java:115) ~[neoforge-21.1.148-universal.jar%23374!/:?]
	at TRANSFORMER/neoforge@21.1.148/net.neoforged.neoforge.network.handling.MainThreadPayloadHandler.lambda$handle$0(MainThreadPayloadHandler.java:16) ~[neoforge-21.1.148-universal.jar%23374!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:60) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.Minecraft.runTick(Minecraft.java:1155) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.Minecraft.run(Minecraft.java:807) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.client.main.Main.main(Main.java:230) ~[client-1.21.1-20240808.144430-srg.jar%23373!/:?]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]
	at MC-BOOTSTRAP/fml_loader@4.0.38/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.38.jar%23111!/:4.0]
	at MC-BOOTSTRAP/fml_loader@4.0.38/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.38.jar%23111!/:4.0]
	at MC-BOOTSTRAP/fml_loader@4.0.38/net.neoforged.fml.loading.targets.CommonClientLaunchHandler.runService(CommonClientLaunchHandler.java:32) ~[loader-4.0.38.jar%23111!/:4.0]
	at MC-BOOTSTRAP/fml_loader@4.0.38/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.38.jar%23111!/:4.0]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23119!/:?]
	at MC-BOOTSTRAP/cpw.mods.modlauncher@11.0.4/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23119!/:?]
	at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?]
	at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?]
[22Apr2025 05:40:10.047] [Render thread/INFO] [ChunkBuilder/]: Stopping worker threads
[22Apr2025 05:40:10.192] [Render thread/WARN] [net.minecraft.client.multiplayer.ClientCommonPacketListenerImpl/]: Client disconnected with reason: Failed to open a screen with advanced data: java.lang.NullPointerException: Cannot invoke "java.util.function.Supplier.get()" because "this.tooltipSupplier" is null

Removing visual overhaul from both client and server resolved the issue.

Let me know if you need anything else on my end (I have the full log of the session if needed) to track this down.