From ecc6a513e092088c71ca8677bcb6bd86e32a44a7 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Mon, 24 Nov 2025 02:35:57 +0900 Subject: [PATCH 1/2] test(react-query-persist-client/PersistQueryClientProvider): replace 'await sleep' with 'sleep().then()' pattern in restoreClient and add additional timer advance for refetch verification --- .../src/__tests__/PersistQueryClientProvider.test.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx b/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx index 10e6948405..3eae33c02f 100644 --- a/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx +++ b/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx @@ -41,8 +41,9 @@ const createMockErrorPersister = ( // noop }, async restoreClient() { - await sleep(10) - throw error + return sleep(10).then(() => { + throw error + }) }, removeClient, }, @@ -415,6 +416,8 @@ describe('PersistQueryClientProvider', () => { expect(rendered.getByText('data: null')).toBeInTheDocument() await act(() => vi.advanceTimersByTimeAsync(10)) expect(rendered.getByText('data: hydrated')).toBeInTheDocument() + await act(() => vi.advanceTimersByTimeAsync(11)) + expect(rendered.getByText('data: hydrated')).toBeInTheDocument() expect(states).toHaveLength(2) From 94c1dc91de0237ec76ea90751a3fe696c76aeb88 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Wed, 17 Dec 2025 10:10:51 +0900 Subject: [PATCH 2/2] refactor(react-query-persist-client/PersistQueryClientProvider.test): convert complex 'then' callbacks to async/await pattern --- .../PersistQueryClientProvider.test.tsx | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx b/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx index 3eae33c02f..6976d851a2 100644 --- a/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx +++ b/packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx @@ -41,9 +41,8 @@ const createMockErrorPersister = ( // noop }, async restoreClient() { - return sleep(10).then(() => { - throw error - }) + await sleep(10) + throw error }, removeClient, }, @@ -385,12 +384,11 @@ describe('PersistQueryClientProvider', () => { function Page() { const state = useQuery({ queryKey: key, - queryFn: () => - sleep(10).then(() => { - fetched = true - return 'fetched' - }), - + queryFn: async () => { + await sleep(10) + fetched = true + return 'fetched' + }, staleTime: Infinity, })