Skip to content

LocKey: separate lockclient and lockservice tests #33

@SUMUKHA-PK

Description

@SUMUKHA-PK

The current situation is like this: One single test file in client which has all tests in the name of TestLockService.
This is misleading and not package specific.
I propose the following:

  1. lockservice tests: These tests will be the same as the existing ones but they call the lockservice API instead of the lockclient API. Basically all the acquire, release without thinking of a client.
  2. lockclient tests: These tests will be only in the domain of the client and use the client interface functions. No calls to the lockservice will be made like in the current tests and all those will be mocked to return the expected value.
  3. LocKey tests: This is IMO what we already have and maybe can be moved outside the two packages in the root directory with an appropriate name.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions