Check-In Type Detail block schedule display bug

[robotman3000]

Description

See actual behavior section. The bug is pretty simple

Actual Behavior

Archived groups that still have a GroupLocationSchedule assigned are included in the list of schedules on the Check-In Type Detail Block

EDIT: This bug also appears to apply to inactive groups

Expected Behavior

Archived groups that still have a GroupLocationSchedule assigned are NOT included in the list of schedules on the Check-In Type Detail Block

Steps to Reproduce

Go to the demo site

For this example I will simulate removing the "Saturday 4:30" after a group that uses it has been archived. The group of choice is "Ushers"

Verify initial state with query

SELECT DISTINCT g.Id, g.Name, g.GroupTypeId, g.IsArchived FROM [GroupLocationSchedule] gls
LEFT JOIN [GroupLocation] gl ON gls.GroupLocationId = gl.Id
LEFT JOIN [Group] g ON gl.GroupId = g.Id
WHERE gls.ScheduleId IN (1)

This should result in 10 rows, none with archived set

This is default state

---- Test 1 ----

Go to Check-In config at volunteer checkin and remove Sat at 4:30 from the ushers group

Verify that the schedule no longer shows up under scheduled times

Also run the query again and there should be only 9 rows now. Ushers should be missing and the schedule should not appear in the Check-In type detail

---- Test 2 ----

Reverse the changes by re-adding Sat 4:30 to the ushers group

Verify that the schedule does show up under scheduled times again
Query should have returned to 10 rows, none archived

Note: At this point something strange happened with the ushers group where it appeared to be duplicated. The duplicate had no parent. Still trying to figure out what happened. Possibly another bug. Will report back with findings

Archive the ushers group with the schedule still assigned in check-in config
Run the query again and note that the ushers group is now archived

the schedule should still appear in the Check-In type detail despite ushers not appearing in the schedule config

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

17.4, 18.1

Client Culture Setting

en-US