Rock Cleanup - Group Inactive and Archived Dates Not Consistently Cleared

[waynehelsby]

Description

Incorrect values are added or removed for InactiveDateTime and ArchivedDateTime

Actual Behavior

• Inactive Date Time on a Group is not cleared consistently
• Archived Date Time on Unarchived Groups is not being removed
• Archived Date Time is being removed from a Group missing one after it is added

Expected Behavior

After Rock Cleanup Job has Run

• Active Groups should not have an InactiveDateTime without depending on unrelated Archived Group cleanup tasks
• Archived Groups should have an ArchivedDateTime
• Unarchived Groups should not have an ArchivedDateTime

Steps to Reproduce

• Create various scenarios of Groups, Statuses and Inactive Date Times/Archived Date Times
• Run Rock Cleanup
• Observe missing or incorrect Inactive and Archived Date Times

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

17.6

Client Culture Setting

en-US