CHAD-17043: Created pre-commit script to check for newline and copyright on all staged lua files #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght on all staged lua files
aleclorimer
requested review from
NoahCornell,
cjswedes,
dljsjr,
tandres and
varzac
tandres
reviewed
Dec 2, 2025
aleclorimer
requested review from
gharveymn,
greens,
hcarter-775 and
nickolas-deboom
gharveymn
reviewed
Dec 3, 2025
cjswedes
reviewed
Dec 3, 2025
gharveymn
reviewed
Dec 3, 2025
tools/pre-commit
Outdated
Comment on lines
8
to
9
| # - Copy to .git/hooks/pre-commit | ||
| # - Ensure executable |
Contributor
There was a problem hiding this comment.
I would suggest just making sure this is committed as executable to avoid the hassle.
Also I would suggest to use a softlink instead of copying, so that you don't need to re-copy it later (ln -s ../../tools/pre-commit .git/hooks/pre-commit (use a relative link so you can move the directory later)).
gharveymn
reviewed
Dec 3, 2025
| # pre-commit | ||
| # | ||
| # - Soft link into .git/hooks/pre-commit | ||
| # - $ ln -s tools/pre-commit .git/hooks/pre-commit |
Contributor
There was a problem hiding this comment.
Maybe it's different with your version of ln, but usually the first argument is assigned to the symlink verbatim, rather than computed from where you invoked the command. So, it should be ../../tools/pre-commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Created a script to check all staged lua files that they end with a newline character and begin with the current year's copyright header. This file should be made executable and copied to
.git/hooks/pre-commit.Type of Change